Skip to content

Update cache dependency paths in CI workflow#213

Open
mubking wants to merge 1 commit intoLabsCrypt:mainfrom
mubking:patch-2
Open

Update cache dependency paths in CI workflow#213
mubking wants to merge 1 commit intoLabsCrypt:mainfrom
mubking:patch-2

Conversation

@mubking
Copy link
Copy Markdown
Contributor

@mubking mubking commented Feb 26, 2026

Description

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧪 Test addition or update

Related Issues

Closes #

Changes Made

Testing

Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Test Steps

Breaking Changes

Breaking Changes:

Migration Guide:

Screenshots/Demo

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have checked for breaking changes and documented them if applicable

Additional Notes

Copy link
Copy Markdown
Contributor

@ogazboiz ogazboiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @mubking, this is a duplicate of #212 — same change, same issue.

the cache-dependency-path should point to the lock file (package-lock.json), not package.json. changing it to package.json is the wrong fix.

the correct approach:

  1. make sure frontend/package-lock.json and backend/package-lock.json exist (run npm install in each directory)
  2. commit those lock files
  3. revert cache-dependency-path back to pointing at the lock files

please close this PR and the other duplicates (#212, #214) and open one clean PR with the right fix. happy to review it quickly!

also come chat with us on Telegram: https://t.me/+DOylgFv1jyJlNzM0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants