Update cache dependency paths in CI workflow#213
Open
mubking wants to merge 1 commit intoLabsCrypt:mainfrom
Open
Update cache dependency paths in CI workflow#213mubking wants to merge 1 commit intoLabsCrypt:mainfrom
mubking wants to merge 1 commit intoLabsCrypt:mainfrom
Conversation
19 tasks
ogazboiz
requested changes
Mar 26, 2026
Contributor
ogazboiz
left a comment
There was a problem hiding this comment.
hey @mubking, this is a duplicate of #212 — same change, same issue.
the cache-dependency-path should point to the lock file (package-lock.json), not package.json. changing it to package.json is the wrong fix.
the correct approach:
- make sure
frontend/package-lock.jsonandbackend/package-lock.jsonexist (runnpm installin each directory) - commit those lock files
- revert
cache-dependency-pathback to pointing at the lock files
please close this PR and the other duplicates (#212, #214) and open one clean PR with the right fix. happy to review it quickly!
also come chat with us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Related Issues
Closes #
Changes Made
Testing
Test Coverage
Test Steps
Breaking Changes
Breaking Changes:
Migration Guide:
Screenshots/Demo
Checklist
Additional Notes