fix(ci): unbreak main — syntax error in adminDisputeController test#44
Merged
Conversation
…Controller test
adminDisputeController.test.ts:527 ended '.set(bearer(TEST_USER))' with a
semicolon, orphaning the following '.send({})' as a dangling expression. That
produced 'Parsing error: Declaration or statement expected' at 528:6, which
broke the Lint step (and tsc build + the test parse) on main, reding the whole
backend CI and blocking every open PR. Chain the calls correctly.
…ttierrc
An empty "prettier": {} block in package.json took precedence over .prettierrc
(printWidth 100), so eslint-plugin-prettier enforced default 80-width formatting
against files that were formatted to 100, producing ~hundreds of prettier/prettier
lint errors across the test suite (while the standalone `prettier --check` — which
resolved .prettierrc — passed). Removing the empty override makes both eslint and
prettier resolve .prettierrc consistently.
…style .prettierrc declared singleQuote:true + printWidth:100, but the entire codebase is formatted to prettier defaults (double quotes, 80 width) — the .prettierrc was never actually applied. Its presence made eslint-plugin-prettier enforce a style the code doesn't use, generating hundreds of prettier/prettier lint errors. With no .prettierrc (and no package.json prettier override), eslint + prettier both use the defaults the code already matches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Main CI has been red on the Lint step (which also fails tsc build + the test parse), blocking every open backend PR.
Cause
src/__tests__/adminDisputeController.test.ts:527ended.set(bearer(TEST_USER))with a stray;, orphaning the next line.send({})→Parsing error: Declaration or statement expectedat 528:6. A bad merge landed it on main.Fix
Remove the semicolon so
.set(...).send({})chains. One line; it was the only parse error (the rest of the lint output is non-blockingno-consolewarnings). This greens Lint + build + test on main.