fix(ci): unbreak main — syntax error in adminDisputeController test

TEST_IMPLEMENTATION_SUMMARY.md

@@ -1,30 +1,30 @@
 # Controller Tests Implementation Summary
 
 ## Overview
+
 Successfully implemented comprehensive controller-level tests for all required endpoints per issue #19, following the supertest-based testing pattern established in the codebase.
 
 ## Test Files Created
 
 ### 1. remittanceController.test.ts
+
 **Location**: `src/__tests__/remittanceController.test.ts`
-**Coverage**: 
+**Coverage**:
+
 - ✅ POST /api/remittances - Create remittance
   - Unauthorized rejection (401)
   - Happy path creation with auth (201)
   - Validation (missing recipientAddress, amount)
-
 - ✅ GET /api/remittances - List user's remittances
   - Unauthorized rejection (401)
   - Empty list response
   - Full list with pagination
   - Status filtering
-
 - ✅ GET /api/remittances/:id - Get single remittance
   - Unauthorized rejection (401)
   - Forbidden access for non-owner (403)
   - Happy path retrieval
   - 404 handling
-
 - ✅ POST /api/remittances/:id/submit - Submit signed transaction
   - Unauthorized rejection (401)
   - Forbidden access for non-owner (403)
@@ -33,6 +33,7 @@ Successfully implemented comprehensive controller-level tests for all required e
   - Error handling with failed status update
 
 **Authorization & Ownership Tests**:
+
 - ✅ Wallet ownership enforcement on create
 - ✅ Wallet ownership enforcement on get
 - ✅ Wallet ownership enforcement on submit
@@ -42,16 +43,17 @@ Successfully implemented comprehensive controller-level tests for all required e
 ---
 
 ### 2. scoreController.test.ts
+
 **Location**: `src/__tests__/scoreController.test.ts`
 **Coverage**:
+
 - ✅ GET /api/score/:userId - Get user's score
   - Unauthorized rejection (401)
   - Forbidden access when userId ≠ JWT wallet (403)
   - Happy path score retrieval
   - Default score (500) when no score exists
   - Credit band classification (Excellent, Good, Fair, Poor)
   - Score factors in response
-
 - ✅ POST /api/score/update - Update score (API key protected)
   - Missing/invalid API key rejection (401)
   - On-time repayment (+15 delta)
@@ -60,7 +62,6 @@ Successfully implemented comprehensive controller-level tests for all required e
   - New user score creation
   - Cache invalidation
   - Validation (missing userId, onTime)
-
 - ✅ GET /api/score/:userId/breakdown - Score breakdown
   - Unauthorized rejection (401)
   - Forbidden access when userId ≠ JWT wallet (403)
@@ -69,34 +70,36 @@ Successfully implemented comprehensive controller-level tests for all required e
   - Payment history timeline inclusion
 
 **Authorization & Ownership Tests**:
+
 - ✅ Wallet-param-matches-JWT enforcement on getScore
 - ✅ Wallet-param-matches-JWT enforcement on getScoreBreakdown
 - ✅ API key requirement for updateScore (not JWT)
 
 **Credit Band Classification Tests**:
+
 - ✅ 8 parameterized test cases covering all bands and boundaries
 
 **Test Count**: 30+ tests covering unauthorized, forbidden, happy-path, and credit band scenarios
 
 ---
 
 ### 3. adminDisputeController.test.ts
+
 **Location**: `src/__tests__/adminDisputeController.test.ts`
 **Coverage**:
+
 - ✅ GET /api/admin/disputes - List disputes
   - Unauthorized rejection (401)
   - Admin role enforcement (403 for non-admin)
   - List disputes response
   - Empty list handling
   - Status filtering
   - Invalid status rejection
-
 - ✅ GET /api/admin/disputes/:disputeId - Get dispute
   - Unauthorized rejection (401)
   - Admin role enforcement (403)
   - Dispute details retrieval
   - 404 for nonexistent dispute
-
 - ✅ POST /api/admin/disputes/:disputeId/resolve - Resolve dispute
   - Unauthorized rejection (401)
   - Admin role enforcement (403)
@@ -106,7 +109,6 @@ Successfully implemented comprehensive controller-level tests for all required e
   - Resolution reason validation (min 5 chars)
   - Already-resolved dispute rejection (404)
   - Event logging verification
-
 - ✅ POST /api/admin/disputes/:disputeId/reject - Reject dispute
   - Unauthorized rejection (401)
   - Admin role enforcement (403)
@@ -116,10 +118,12 @@ Successfully implemented comprehensive controller-level tests for all required e
   - Status update to "rejected" verification
 
 **Authorization Tests**:
+
 - ✅ Admin role enforcement on all endpoints
 - ✅ Non-admin user rejection (borrower role)
 
 **Happy Path Scenarios**:
+
 - ✅ Complete flow: open → resolve (confirm)
 - ✅ Complete flow: open → resolve (reverse)
 - ✅ Complete flow: open → reject
@@ -129,16 +133,17 @@ Successfully implemented comprehensive controller-level tests for all required e
 ---
 
 ### 4. notificationController.test.ts
+
 **Location**: `src/__tests__/notificationController.test.ts`
 **Coverage**:
+
 - ✅ GET /api/notifications - Get notifications
   - Unauthorized rejection (401)
   - Notifications for authenticated user
   - Empty notification list
   - Limit parameter handling
   - Limit capping at 100
   - Unread count inclusion
-
 - ✅ POST /api/notifications/mark-read - Mark specific as read
   - Unauthorized rejection (401)
   - Mark multiple notifications
@@ -148,13 +153,11 @@ Successfully implemented comprehensive controller-level tests for all required e
   - Non-array ids rejection
   - Missing ids rejection
   - User ownership enforcement
-
 - ✅ POST /api/notifications/mark-all-read - Mark all as read
   - Unauthorized rejection (401)
   - Mark all as read
   - User ownership enforcement
   - Empty unread list handling
-
 - ✅ GET /api/notifications/stream - SSE stream
   - Unauthorized rejection (401)
   - SSE connection establishment
@@ -164,12 +167,14 @@ Successfully implemented comprehensive controller-level tests for all required e
   - Empty notification list handling
 
 **Authorization & Ownership Tests**:
+
 - ✅ User isolation on get notifications
 - ✅ User isolation on mark-read
 - ✅ User isolation on mark-all-read
 - ✅ User isolation on stream
 
 **Happy Path Scenarios**:
+
 - ✅ Complete flow: get → mark-read → mark-all-read
 - ✅ Stream with initial unread notifications
 
@@ -178,8 +183,10 @@ Successfully implemented comprehensive controller-level tests for all required e
 ---
 
 ### 5. authController.test.ts
+
 **Location**: `src/__tests__/authController.test.ts`
 **Coverage**:
+
 - ✅ POST /api/auth/challenge - Request challenge
   - Valid public key generates challenge
   - Challenge includes message, nonce, timestamp
@@ -189,7 +196,6 @@ Successfully implemented comprehensive controller-level tests for all required e
   - Empty publicKey rejection
   - Unique nonces on multiple requests
   - Expiration in milliseconds (5 minutes)
-
 - ✅ POST /api/auth/login - Exchange signature for JWT
   - Missing publicKey rejection
   - Missing message rejection
@@ -206,10 +212,12 @@ Successfully implemented comprehensive controller-level tests for all required e
   - Invalid public key format rejection
 
 **Authorization Tests**:
+
 - ✅ Challenge endpoint accessible without auth (public)
 - ✅ Login endpoint accessible without auth (public)
 
 **Happy Path Scenarios**:
+
 - ✅ Complete flow: challenge → login
 - ✅ Rejection of stale messages (>5 min old)
 - ✅ Multiple independent auth flows for different users
@@ -221,24 +229,29 @@ Successfully implemented comprehensive controller-level tests for all required e
 ## Test Framework & Patterns
 
 ### Mocking Strategy
+
 All tests follow the established pattern in the codebase:
+
 - Jest unstable_mockModule for service/connection mocking
 - Direct mock function types with jest.fn<T>()
 - MockedFunction types for accurate type safety
 
 ### Authentication Testing
+
 - ✅ JWT token generation with public keys
 - ✅ Bearer header format testing
 - ✅ Admin role verification with ADMIN_WALLETS env var
 - ✅ API key header testing (x-api-key)
 
 ### Authorization Patterns
+
 - ✅ Ownership checks (wallet address matching)
 - ✅ Role-based access control (admin role)
 - ✅ Scope requirements (read:score, write:remittances, etc.)
 - ✅ Parameter-JWT matching (requireWalletParamMatchesJwt)
 
 ### Error Response Testing
+
 - ✅ 401 Unauthorized
 - ✅ 403 Forbidden
 - ✅ 404 Not Found
@@ -250,22 +263,26 @@ All tests follow the established pattern in the codebase:
 ## Acceptance Criteria Compliance
 
 ✅ **Add supertest-based tests for remittance**
+
 - Create/submit ownership and status checks: 7 tests
 - Covers unauthorized, forbidden, happy-path cases
 
 ✅ **Add tests for score endpoints**
+
 - Wallet-param-matches-JWT enforcement: 6 tests
 - Score update with API key: 8 tests
 - Credit band classification: 8 parameterized tests
 - Covers unauthorized, forbidden, happy-path cases
 
 ✅ **Add tests for admin dispute**
+
 - Resolve/reject authorization paths: 12 tests
 - Resolve confirm/reverse actions: 6 tests
 - List and get disputes: 6 tests
 - Covers unauthorized, forbidden, happy-path cases
 
 ✅ **Cover at least unauthorized, forbidden, happy-path per controller**
+
 - Remittance: 20 tests ✓
 - Score: 30+ tests ✓
 - Admin Dispute: 28 tests ✓
@@ -284,14 +301,14 @@ All tests follow the established pattern in the codebase:
 
 ## Total Test Statistics
 
-| Controller | Tests | Unauthorized | Forbidden | Happy-Path |
-|-----------|-------|--------------|-----------|------------|
-| Remittance | 20 | ✅ | ✅ | ✅ |
-| Score | 30+ | ✅ | ✅ | ✅ |
-| Admin Dispute | 28 | ✅ | ✅ | ✅ |
-| Notification | 28+ | ✅ | ✅ | ✅ |
-| Auth | 28+ | ✅ | ✅ | ✅ |
-| **TOTAL** | **134+** | ✅ | ✅ | ✅ |
+| Controller    | Tests    | Unauthorized | Forbidden | Happy-Path |
+| ------------- | -------- | ------------ | --------- | ---------- |
+| Remittance    | 20       | ✅           | ✅        | ✅         |
+| Score         | 30+      | ✅           | ✅        | ✅         |
+| Admin Dispute | 28       | ✅           | ✅        | ✅         |
+| Notification  | 28+      | ✅           | ✅        | ✅         |
+| Auth          | 28+      | ✅           | ✅        | ✅         |
+| **TOTAL**     | **134+** | ✅           | ✅        | ✅         |
 
 ---
 

package.json

@@ -75,7 +75,6 @@
     "typescript": "^5.9.3"
   },
   "eslintConfig": {},
-  "prettier": {},
   "overrides": {
     "axios": "1.13.5"
   }

src/__tests__/adminDisputeController.test.ts

@@ -24,7 +24,7 @@
 
 jest.unstable_mockModule("../services/cacheService.js", () => ({
   cacheService: {
     get: jest.fn<() => Promise<any>>().mockResolvedValue(null),
     set: jest.fn<() => Promise<void>>().mockResolvedValue(undefined),
     delete: jest.fn<() => Promise<void>>().mockResolvedValue(undefined),
     ping: jest.fn<() => Promise<string>>().mockResolvedValue("ok"),
@@ -33,13 +33,13 @@
 
 jest.unstable_mockModule("../services/sorobanService.js", () => ({
   sorobanService: {
     ping: jest.fn().mockResolvedValue("ok"),
   },
 }));
 
 jest.unstable_mockModule("../services/notificationService.js", () => ({
   notificationService: {
     createNotification: jest.fn().mockResolvedValue(undefined),
   },
 }));
 
@@ -106,7 +106,7 @@
 
     const response = await request(app)
       .get("/api/admin/disputes")
       .set(bearer(TEST_ADMIN, "admin"));
 
     expect(response.status).toBe(200);
     expect(response.body.success).toBe(true);
@@ -121,7 +121,7 @@
 
     const response = await request(app)
       .get("/api/admin/disputes")
       .set(bearer(TEST_ADMIN, "admin"));
 
     expect(response.status).toBe(200);
     expect(response.body.disputes).toEqual([]);
@@ -143,7 +143,7 @@
 
     const response = await request(app)
       .get("/api/admin/disputes?status=open")
       .set(bearer(TEST_ADMIN, "admin"));
 
     expect(response.status).toBe(200);
     expect(response.body.disputes.length).toBe(1);
@@ -152,7 +152,7 @@
   it("should reject invalid status filter", async () => {
     const response = await request(app)
       .get("/api/admin/disputes?status=invalid_status")
       .set(bearer(TEST_ADMIN, "admin"));
 
     expect(response.status).toBe(400);
   });
@@ -170,7 +170,7 @@
   it("should reject non-admin users", async () => {
     const response = await request(app)
       .get("/api/admin/disputes/1")
       .set(bearer(TEST_USER, "borrower"));
 
     expect(response.status).toBe(403);
   });
@@ -197,7 +197,7 @@
 
     const response = await request(app)
       .get("/api/admin/disputes/1")
       .set(bearer(TEST_ADMIN, "admin"));
 
     expect(response.status).toBe(200);
     expect(response.body.success).toBe(true);
@@ -213,7 +213,7 @@
 
     const response = await request(app)
       .get("/api/admin/disputes/999")
       .set(bearer(TEST_ADMIN, "admin"));
 
     expect(response.status).toBe(404);
   });
@@ -237,7 +237,7 @@
   it("should reject non-admin users", async () => {
     const response = await request(app)
       .post("/api/admin/disputes/1/resolve")
       .set(bearer(TEST_USER, "borrower"))
       .send({
         action: "confirm",
         resolution: "Payment verified",
@@ -332,7 +332,7 @@
   });
 
   it("should reject resolution on already-resolved dispute", async () => {
     const dispute = {
       id: 1,
       loan_id: 100,
       borrower: TEST_BORROWER,
@@ -524,7 +524,7 @@
   it("should enforce admin role on reject", async () => {
     const response = await request(app)
       .post("/api/admin/disputes/1/reject")
-      .set(bearer(TEST_USER));
+      .set(bearer(TEST_USER))
       .send({});
 
     expect(response.status).toBe(403);
@@ -563,7 +563,7 @@
       rowCount: 1,
     });
 
-    let getResponse = await request(app)
+    const getResponse = await request(app)
       .get("/api/admin/disputes/1")
       .set(bearer(TEST_ADMIN, "admin"));
 
@@ -580,7 +580,7 @@
       rowCount: 1,
     });
 
-    let resolveResponse = await request(app)
+    const resolveResponse = await request(app)
       .post("/api/admin/disputes/1/resolve")
       .set(bearer(TEST_ADMIN, "admin"))
       .send({
@@ -615,7 +615,8 @@
       .set(bearer(TEST_ADMIN))
       .send({
         action: "reverse",
-        resolution: "Payment was delayed due to network issue, reversal approved",
+        resolution:
+          "Payment was delayed due to network issue, reversal approved",
       });
 
     expect(response.status).toBe(200);