Skip to content

Fix branch#662

Open
onyillto wants to merge 4 commits intoLabsCrypt:mainfrom
onyillto:fix_branch
Open

Fix branch#662
onyillto wants to merge 4 commits intoLabsCrypt:mainfrom
onyillto:fix_branch

Conversation

@onyillto
Copy link
Copy Markdown

No description provided.

useSSE.ts — a React hook, purely client-side
setInterval polling fallback — browser JavaScript

LabsCrypt#577
Copy link
Copy Markdown
Contributor

@ogazboiz ogazboiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @onyillto, there are some good changes here but this PR bundles 4 unrelated things together which makes it hard to review and increases risk:

  1. backend: env validation test safety (throws instead of process.exit in test env)
  2. frontend: WalletProvider signTransaction implementation
  3. frontend: useSSE polling fallback
  4. frontend: package-lock.json change (stray file)

could you split these into separate PRs? each one is a focused improvement and would be easier to review and merge individually.

also, the package-lock.json change (marking a package as dev-only) seems unrelated to everything else. please drop that from any re-submission.

let me know if you have questions!

@ogazboiz
Copy link
Copy Markdown
Contributor

The codebase issues on main have been resolved and all CI checks are passing now. Please rebase your branch to pull in the latest changes before continuing. Thanks for your patience.

@ogazboiz ogazboiz mentioned this pull request Mar 30, 2026
Copy link
Copy Markdown
Contributor

@ogazboiz ogazboiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be closed. The appended code uses ink!/Substrate macros (#[ink(storage)], scale::Encode) but the existing contract is Soroban. These are completely different blockchain frameworks and incompatible. Branch name fix_branch is also generic.

@ogazboiz
Copy link
Copy Markdown
Contributor

Just following up on this. The code in this PR uses ink!/Substrate framework macros but the project uses Soroban. These are incompatible frameworks. I'd recommend closing this PR and opening a new one that integrates with the existing Soroban contract structure instead.

@ogazboiz
Copy link
Copy Markdown
Contributor

heads up, a few important changes just landed on main that affect your PR:

  1. axios pinned to 1.13.5 - there's an active supply chain attack on axios 1.14.1 (pulls in confirmed malware). we added overrides in all package.json files to block it.

  2. CI now runs a supply chain audit before backend/frontend jobs. if your lockfile has a compromised package, CI will fail with a clear error.

  3. backend test fixes - loanEndpoints tests now use valid Stellar addresses and base64 strings. if your PR was failing backend CI but you didn't touch backend code, this should fix it after rebase.

please rebase on latest main:

git fetch upstream
git rebase upstream/main
git push --force-with-lease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants