Skip to content

refactor(sonar): grouped fixes#17

Merged
ReenigneArcher merged 3 commits into
masterfrom
refactor/sonar
Jun 20, 2026
Merged

refactor(sonar): grouped fixes#17
ReenigneArcher merged 3 commits into
masterfrom
refactor/sonar

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Fixes remaining sonar issues.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@read-the-docs-community

read-the-docs-community Bot commented Jun 20, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.67227% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.03%. Comparing base (a81912f) to head (409eddb).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/platform/linux/uhid_backend.cpp 73.56% 9 Missing and 14 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   87.38%   87.03%   -0.35%     
==========================================
  Files          10       10              
  Lines        3322     3194     -128     
  Branches     1157     1161       +4     
==========================================
- Hits         2903     2780     -123     
  Misses        260      260              
+ Partials      159      154       -5     
Flag Coverage Δ
Linux-Clang 68.61% <65.76%> (-0.50%) ⬇️
Linux-GCC 81.16% <71.15%> (-0.77%) ⬇️
Windows-MSVC 84.94% <100.00%> (+0.58%) ⬆️
Windows-MinGW-UCRT64 74.47% <76.92%> (+0.80%) ⬆️
macOS 66.87% <62.50%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/core/runtime.cpp 83.75% <100.00%> (+1.21%) ⬆️
src/core/types.cpp 65.85% <100.00%> (ø)
src/include/libvirtualhid/runtime.hpp 100.00% <ø> (ø)
src/platform/linux/uhid_backend.cpp 87.95% <73.56%> (-1.19%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a81912f...409eddb. Read the comment docs.

@ReenigneArcher ReenigneArcher merged commit ccad17c into master Jun 20, 2026
23 of 24 checks passed
@ReenigneArcher ReenigneArcher deleted the refactor/sonar branch June 20, 2026 17:20
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant