refactor(sonar): grouped fixes

CMakeLists.txt

@@ -8,7 +8,7 @@ project(libvirtualhid VERSION 0.0.0
         LANGUAGES CXX)
 
 set(PROJECT_LICENSE "MIT")
-set(CMAKE_CXX_STANDARD 20)
+set(CMAKE_CXX_STANDARD 23)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
 set(CMAKE_CXX_EXTENSIONS OFF)
 

src/CMakeLists.txt

@@ -51,7 +51,7 @@ target_include_directories(${PROJECT_NAME}
   PRIVATE
   "${CMAKE_CURRENT_SOURCE_DIR}")
 
-target_compile_features(${PROJECT_NAME} PUBLIC cxx_std_20)
+target_compile_features(${PROJECT_NAME} PUBLIC cxx_std_23)
 set_target_properties(${PROJECT_NAME} PROPERTIES
   EXPORT_NAME libvirtualhid
   OUTPUT_NAME virtualhid)

src/core/runtime.cpp

@@ -305,7 +305,12 @@ namespace lvh {
 
   Gamepad::Gamepad(Gamepad &&) noexcept = default;
   Gamepad &Gamepad::operator=(Gamepad &&) noexcept = default;
-  Gamepad::~Gamepad() = default;
+
+  Gamepad::~Gamepad() {
+    if (device_) {
+      static_cast<void>(close());
+    }
+  }
 
   DeviceId Gamepad::device_id() const {
     return device_->id;
@@ -425,7 +430,12 @@ namespace lvh {
 
   Keyboard::Keyboard(Keyboard &&) noexcept = default;
   Keyboard &Keyboard::operator=(Keyboard &&) noexcept = default;
-  Keyboard::~Keyboard() = default;
+
+  Keyboard::~Keyboard() {
+    if (device_) {
+      static_cast<void>(close());
+    }
+  }
 
   DeviceId Keyboard::device_id() const {
     return device_->id;
@@ -531,7 +541,12 @@ namespace lvh {
 
   Mouse::Mouse(Mouse &&) noexcept = default;
   Mouse &Mouse::operator=(Mouse &&) noexcept = default;
-  Mouse::~Mouse() = default;
+
+  Mouse::~Mouse() {
+    if (device_) {
+      static_cast<void>(close());
+    }
+  }
 
   DeviceId Mouse::device_id() const {
     return device_->id;
@@ -641,7 +656,12 @@ namespace lvh {
 
   Touchscreen::Touchscreen(Touchscreen &&) noexcept = default;
   Touchscreen &Touchscreen::operator=(Touchscreen &&) noexcept = default;
-  Touchscreen::~Touchscreen() = default;
+
+  Touchscreen::~Touchscreen() {
+    if (device_) {
+      static_cast<void>(close());
+    }
+  }
 
   DeviceId Touchscreen::device_id() const {
     return device_->id;
@@ -743,7 +763,12 @@ namespace lvh {
 
   Trackpad::Trackpad(Trackpad &&) noexcept = default;
   Trackpad &Trackpad::operator=(Trackpad &&) noexcept = default;
-  Trackpad::~Trackpad() = default;
+
+  Trackpad::~Trackpad() {
+    if (device_) {
+      static_cast<void>(close());
+    }
+  }
 
   DeviceId Trackpad::device_id() const {
     return device_->id;
@@ -862,7 +887,12 @@ namespace lvh {
 
   PenTablet::PenTablet(PenTablet &&) noexcept = default;
   PenTablet &PenTablet::operator=(PenTablet &&) noexcept = default;
-  PenTablet::~PenTablet() = default;
+
+  PenTablet::~PenTablet() {
+    if (device_) {
+      static_cast<void>(close());
+    }
+  }
 
   DeviceId PenTablet::device_id() const {
     return device_->id;

src/core/types.cpp

@@ -42,7 +42,7 @@ namespace lvh {
   }
 
   void ButtonSet::set(GamepadButton button, bool pressed) {
-    const auto mask = 1U << static_cast<std::uint8_t>(button);
+    const auto mask = 1U << std::to_underlying(button);
     if (pressed) {
       bits_ |= mask;
     } else {
@@ -59,7 +59,7 @@ namespace lvh {
   }
 
   bool ButtonSet::test(GamepadButton button) const {
-    return (bits_ & (1U << static_cast<std::uint8_t>(button))) != 0;
+    return (bits_ & (1U << std::to_underlying(button))) != 0;
   }
 
   std::uint32_t ButtonSet::raw_bits() const {

src/include/libvirtualhid/runtime.hpp

@@ -123,7 +123,7 @@ namespace lvh {
     Gamepad(detail::RuntimeConstructionToken token, std::shared_ptr<detail::GamepadDevice> device);
 
     /**
-     * @brief Destroy the gamepad handle.
+     * @brief Destroy the gamepad handle and close the virtual device if it is still open.
      */
     ~Gamepad() override;
 
@@ -248,7 +248,7 @@ namespace lvh {
     Keyboard(detail::RuntimeConstructionToken token, std::shared_ptr<detail::KeyboardDevice> device);
 
     /**
-     * @brief Destroy the keyboard handle.
+     * @brief Destroy the keyboard handle and close the virtual device if it is still open.
      */
     ~Keyboard() override;
 
@@ -368,7 +368,7 @@ namespace lvh {
     Mouse(detail::RuntimeConstructionToken token, std::shared_ptr<detail::MouseDevice> device);
 
     /**
-     * @brief Destroy the mouse handle.
+     * @brief Destroy the mouse handle and close the virtual device if it is still open.
      */
     ~Mouse() override;
 
@@ -509,7 +509,7 @@ namespace lvh {
     Touchscreen(detail::RuntimeConstructionToken token, std::shared_ptr<detail::TouchscreenDevice> device);
 
     /**
-     * @brief Destroy the touchscreen handle.
+     * @brief Destroy the touchscreen handle and close the virtual device if it is still open.
      */
     ~Touchscreen() override;
 
@@ -613,7 +613,7 @@ namespace lvh {
     Trackpad(detail::RuntimeConstructionToken token, std::shared_ptr<detail::TrackpadDevice> device);
 
     /**
-     * @brief Destroy the trackpad handle.
+     * @brief Destroy the trackpad handle and close the virtual device if it is still open.
      */
     ~Trackpad() override;
 
@@ -725,7 +725,7 @@ namespace lvh {
     PenTablet(detail::RuntimeConstructionToken token, std::shared_ptr<detail::PenTabletDevice> device);
 
     /**
-     * @brief Destroy the pen tablet handle.
+     * @brief Destroy the pen tablet handle and close the virtual device if it is still open.
      */
     ~PenTablet() override;