test: improve SearchOperationsTest postgres coverage#3340
test: improve SearchOperationsTest postgres coverage#3340msmithstubbs wants to merge 3 commits intoLogflare:mainfrom
Conversation
cfe64e4 to
8a6963a
Compare
amokan
left a comment
There was a problem hiding this comment.
Hey @msmithstubbs 👋
The test changes look good. My only concern is the addition of the rescue block in search operations - which does change production behavior a bit.
If there is a need to include the rescue block, could we at least tighten that up to only rescue Postgrex.Error?
c404024 to
f13bfe7
Compare
Yeah, you're right: we don't need it. I've removed it and updated the test to assert any exceptions are passed through. Might be worth considering rescuing some exceptions to align the Postgres code path closer to BigQuery but that should be a separate PR. |
Implement feedback on test improvements from #3307