Split PR #167 into wave module changes#176
Merged
simmsa merged 20 commits intoMHKiT-Software:developfrom Sep 23, 2025
Merged
Conversation
Contributor
Author
|
@MShabara sounds good! Thank you for taking a look. I just need to update the changelog and then I will merge this. |
These changes are more complex than anticipated and need to be moved to a new branch and PR.
f58ae31 to
6dc9b36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR takes the wave module code from PR #167 but specifically excludes short_term_extreme.m changes which are failing tests and require additional effort.
List of changes:
examplesfrom input file pathexamplesfrom input file path