Conversation
🍹
|
There was a problem hiding this comment.
Pull request overview
This pull request appears to be making changes that would destroy staging infrastructure. The PR includes a dangerous modification to the GitHub Actions workflow that changes the Pulumi command from preview to destroy, along with a minor formatting change to a Pulumi configuration file.
- Changed Pulumi workflow command from preview to destroy in the staging deployment workflow
- Added a blank line to the end of the VPC Pulumi configuration file
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/pulumi_staging.yaml |
Modified the Pulumi Preview step to run destroy instead of preview - this will destroy staging infrastructure |
pulumi/environments/aws/staging/40-vpc/Pulumi.yaml |
Added trailing blank line (formatting only) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| always-include-summary: true | ||
| cloud-url: ${{ env.PULUMI_CLOUD_URL_STAGING }} | ||
| command: preview | ||
| command: destroy #preview |
There was a problem hiding this comment.
The command has been changed from "preview" to "destroy", which will destroy staging infrastructure instead of previewing changes. This is extremely dangerous as it runs on pull requests and when pushing to main. The step name is "Pulumi Preview" but the actual command is "destroy", creating a critical mismatch. If this change is merged, it will destroy the staging environment when the workflow runs.
| command: destroy #preview | |
| command: preview |
No description provided.