Skip to content

Delete #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sekka1 wants to merge 2 commits into from
Closed

Delete #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bab9ad9
Add empty line for better readability in Pulumi.yaml
sekka1 Dec 30, 2025
b1ad91c
Change Pulumi command from preview to destroy
sekka1 Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pulumi_staging.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ jobs:
with:
always-include-summary: true
cloud-url: ${{ env.PULUMI_CLOUD_URL_STAGING }}
command: preview
command: destroy #preview
Copy link

Copilot AI Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command has been changed from "preview" to "destroy", which will destroy staging infrastructure instead of previewing changes. This is extremely dangerous as it runs on pull requests and when pushing to main. The step name is "Pulumi Preview" but the actual command is "destroy", creating a critical mismatch. If this change is merged, it will destroy the staging environment when the workflow runs.

Suggested change
command: destroy #preview
command: preview

Copilot uses AI. Check for mistakes.
comment-on-pr: true
comment-on-summary: true
stack-name: organization/${{ steps.getStackName.outputs.result }}/${{ env.DEPLOY_ENVIRONMENT }}
Expand Down
1 change: 1 addition & 0 deletions pulumi/environments/aws/staging/40-vpc/Pulumi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,4 @@ outputs:
internet_gateway_id: ${staging-vpc.internetGatewayId}
nat_gateway_ids: ${staging-vpc.natGatewayIds}
default_security_group_id: ${staging-vpc.defaultSecurityGroupId}

Loading