chore: upgrade angular#190
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades Angular and TypeScript dependencies, formats several components, and updates compiler configurations. However, it introduces critical compilation errors by importing and calling the non-existent withNoIncrementalHydration function in app.config.ts, and by using an invalid ChangeDetectionStrategy.Eager across multiple components. Additionally, there is an unintentional downgrade of postcss in package.json, and the suppression of template diagnostics in tsconfig.app.json is discouraged.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| import { | ||
| provideClientHydration, | ||
| withEventReplay, | ||
| withNoIncrementalHydration, | ||
| } from '@angular/platform-browser'; |
There was a problem hiding this comment.
withNoIncrementalHydration does not exist in @angular/platform-browser. Incremental hydration is disabled by default in Angular, so there is no need for a disabling function. This import will cause a compilation error.
import {
provideClientHydration,
withEventReplay,
} from '@angular/platform-browser';| providers: [ | ||
| provideBrowserGlobalErrorListeners(), | ||
| provideRouter(routes), | ||
| provideClientHydration(withEventReplay(), withNoIncrementalHydration()), |
There was a problem hiding this comment.
Remove the non-existent withNoIncrementalHydration() call to prevent compilation errors.
| provideClientHydration(withEventReplay(), withNoIncrementalHydration()), | |
| provideClientHydration(withEventReplay()), |
| standalone: true, | ||
| imports: [RouterOutlet, NavigationBar, Footer], | ||
| templateUrl: './app.html', | ||
| styleUrl: './app.css', |
There was a problem hiding this comment.
ChangeDetectionStrategy.Eager is not a valid Angular change detection strategy. Angular only supports Default and OnPush. Using Eager will cause a compilation error. For better performance, it is recommended to use OnPush.
| styleUrl: './app.css', | |
| changeDetection: ChangeDetectionStrategy.OnPush, |
| standalone: true, | ||
| templateUrl: './foliary-card.html', | ||
| styleUrl: './foliary-card.css', | ||
| host: { |
There was a problem hiding this comment.
ChangeDetectionStrategy.Eager is not a valid Angular change detection strategy. Angular only supports Default and OnPush. Using Eager will cause a compilation error. For better performance, it is recommended to use OnPush.
| host: { | |
| changeDetection: ChangeDetectionStrategy.OnPush, |
| standalone: true, | ||
| templateUrl: './foliary-outlined-button.html', | ||
| styleUrl: './foliary-outlined-button.css', | ||
| host: { |
There was a problem hiding this comment.
ChangeDetectionStrategy.Eager is not a valid Angular change detection strategy. Angular only supports Default and OnPush. Using Eager will cause a compilation error. For better performance, it is recommended to use OnPush.
| host: { | |
| changeDetection: ChangeDetectionStrategy.OnPush, |
| standalone: true, | ||
| imports: [CommonModule], | ||
| templateUrl: './footer.html', | ||
| styleUrl: './footer.css', |
There was a problem hiding this comment.
ChangeDetectionStrategy.Eager is not a valid Angular change detection strategy. Angular only supports Default and OnPush. Using Eager will cause a compilation error. For better performance, it is recommended to use OnPush.
| styleUrl: './footer.css', | |
| changeDetection: ChangeDetectionStrategy.OnPush, |
| standalone: true, | ||
| imports: [CommonModule], | ||
| templateUrl: './navigation-bar.html', | ||
| styleUrl: './navigation-bar.css', |
There was a problem hiding this comment.
ChangeDetectionStrategy.Eager is not a valid Angular change detection strategy. Angular only supports Default and OnPush. Using Eager will cause a compilation error. For better performance, it is recommended to use OnPush.
| styleUrl: './navigation-bar.css', | |
| changeDetection: ChangeDetectionStrategy.OnPush, |
| standalone: true, | ||
| imports: [FoliaryCard, FoliaryPrimaryButton], | ||
| templateUrl: './under-construction.html', | ||
| styleUrl: './under-construction.css', |
There was a problem hiding this comment.
ChangeDetectionStrategy.Eager is not a valid Angular change detection strategy. Angular only supports Default and OnPush. Using Eager will cause a compilation error. For better performance, it is recommended to use OnPush.
| styleUrl: './under-construction.css', | |
| changeDetection: ChangeDetectionStrategy.OnPush, |
| "@tailwindcss/postcss": "^4.3.2", | ||
| "@types/express": "^5.0.1", | ||
| "@types/node": "^26.1.1", | ||
| "postcss": "^8.5.3", |
There was a problem hiding this comment.
The version of postcss was downgraded from ^8.5.16 to ^8.5.3. This seems unintentional during an upgrade PR. It is recommended to keep it at ^8.5.16 or upgrade to the latest version.
| "postcss": "^8.5.3", | |
| "postcss": "^8.5.16", |
| "nullishCoalescingNotNullable": "suppress", | ||
| "optionalChainNotNullable": "suppress" |
There was a problem hiding this comment.
Suppressing nullishCoalescingNotNullable and optionalChainNotNullable diagnostics is discouraged as it hides redundant or useless operators in your templates, which can lead to dead code or misleading type safety assumptions. It is recommended to set these to warning or error to maintain code quality.
| "nullishCoalescingNotNullable": "suppress", | |
| "optionalChainNotNullable": "suppress" | |
| "nullishCoalescingNotNullable": "warning", | |
| "optionalChainNotNullable": "warning" |
1 participant
Description
Type of Change
Checklist