Skip to content

chore: upgrade angular #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MessiasLima merged 3 commits into from
Jul 20, 2026
Merged

chore: upgrade angular #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
762ccff
update package-lock.json
MessiasLima Jul 20, 2026
7b906e2
upgrade angular to 22
MessiasLima Jul 20, 2026
ac43fcd
remove custom change detection
MessiasLima Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3,346 changes: 1,685 additions & 1,661 deletions website/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

72 changes: 36 additions & 36 deletions website/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,38 +1,38 @@
{
"name": "foliary",
"version": "0.0.0",
"scripts": {
"ng": "ng",
"start": "ng serve",
"build": "ng build",
"watch": "ng build --watch --configuration development",
"serve:ssr:foliary": "node dist/foliary/server/server.mjs"
},
"private": true,
"packageManager": "npm@11.6.2",
"dependencies": {
"@angular/common": "^21.2.13",
"@angular/compiler": "^21.2.13",
"@angular/core": "^21.2.13",
"@angular/forms": "^21.2.13",
"@angular/platform-browser": "^21.2.13",
"@angular/platform-server": "^21.2.13",
"@angular/router": "^21.2.13",
"@angular/ssr": "^21.2.11",
"express": "^5.1.0",
"rxjs": "~7.8.0",
"tslib": "^2.3.0"
},
"devDependencies": {
"@angular/build": "^21.2.11",
"@angular/cli": "^21.2.11",
"@angular/compiler-cli": "^21.2.13",
"@tailwindcss/postcss": "^4.3.2",
"@types/express": "^5.0.1",
"@types/node": "^26.1.1",
"postcss": "^8.5.16",
"prettier": "^3.9.5",
"tailwindcss": "^4.3.0",
"typescript": "~5.9.3"
}
"name": "foliary",
"version": "0.0.0",
"scripts": {
"ng": "ng",
"start": "ng serve",
"build": "ng build",
"watch": "ng build --watch --configuration development",
"serve:ssr:foliary": "node dist/foliary/server/server.mjs"
},
"private": true,
"packageManager": "npm@11.6.2",
"dependencies": {
"@angular/common": "^22.0.7",
"@angular/compiler": "^22.0.7",
"@angular/core": "^22.0.7",
"@angular/forms": "^22.0.7",
"@angular/platform-browser": "^22.0.7",
"@angular/platform-server": "^22.0.7",
"@angular/router": "^22.0.7",
"@angular/ssr": "^22.0.7",
"express": "^5.1.0",
"rxjs": "~7.8.0",
"tslib": "^2.3.0"
},
"devDependencies": {
"@angular/build": "^22.0.7",
"@angular/cli": "^22.0.7",
"@angular/compiler-cli": "^22.0.7",
"@tailwindcss/postcss": "^4.3.2",
"@types/express": "^5.0.1",
"@types/node": "^26.1.1",
"postcss": "^8.5.3",

@gemini-code-assist gemini-code-assist Bot Jul 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version of postcss was downgraded from ^8.5.16 to ^8.5.3. This seems unintentional during an upgrade PR. It is recommended to keep it at ^8.5.16 or upgrade to the latest version.

Suggested change
"postcss": "^8.5.3",
"postcss": "^8.5.16",

"prettier": "^3.9.5",
"tailwindcss": "^4.3.0",
"typescript": "~6.0.3"
}
}
15 changes: 10 additions & 5 deletions website/src/app/app.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,16 @@ import { ApplicationConfig, provideBrowserGlobalErrorListeners } from '@angular/
import { provideRouter } from '@angular/router';

import { routes } from './app.routes';
import { provideClientHydration, withEventReplay } from '@angular/platform-browser';
import {
provideClientHydration,
withEventReplay,
withNoIncrementalHydration,
} from '@angular/platform-browser';
Comment on lines +5 to +9

@gemini-code-assist gemini-code-assist Bot Jul 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

withNoIncrementalHydration does not exist in @angular/platform-browser. Incremental hydration is disabled by default in Angular, so there is no need for a disabling function. This import will cause a compilation error.

import {
    provideClientHydration,
    withEventReplay,
} from '@angular/platform-browser';


export const appConfig: ApplicationConfig = {
providers: [
provideBrowserGlobalErrorListeners(),
provideRouter(routes), provideClientHydration(withEventReplay())
]
providers: [
provideBrowserGlobalErrorListeners(),
provideRouter(routes),
provideClientHydration(withEventReplay(), withNoIncrementalHydration()),

@gemini-code-assist gemini-code-assist Bot Jul 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Remove the non-existent withNoIncrementalHydration() call to prevent compilation errors.

Suggested change
provideClientHydration(withEventReplay(), withNoIncrementalHydration()),
provideClientHydration(withEventReplay()),

],
};
13 changes: 6 additions & 7 deletions website/src/app/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,10 @@ import { NavigationBar } from './component/navigation-bar/navigation-bar';
import { Footer } from './component/footer/footer';

@Component({
selector: 'app-root',
standalone: true,
imports: [RouterOutlet, NavigationBar, Footer],
templateUrl: './app.html',
styleUrl: './app.css'
selector: 'app-root',
standalone: true,
imports: [RouterOutlet, NavigationBar, Footer],
templateUrl: './app.html',
styleUrl: './app.css',

@gemini-code-assist gemini-code-assist Bot Jul 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

ChangeDetectionStrategy.Eager is not a valid Angular change detection strategy. Angular only supports Default and OnPush. Using Eager will cause a compilation error. For better performance, it is recommended to use OnPush.

Suggested change
styleUrl: './app.css',
changeDetection: ChangeDetectionStrategy.OnPush,

})
export class App {
}
export class App {}
17 changes: 8 additions & 9 deletions website/src/app/component/foliary-card/foliary-card.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
import { Component } from '@angular/core';

@Component({
selector: 'foliary-card',
standalone: true,
templateUrl: './foliary-card.html',
styleUrl: './foliary-card.css',
host: {
'class': 'bg-surface text-on-surface border border-outline rounded-xl'
}
selector: 'foliary-card',
standalone: true,
templateUrl: './foliary-card.html',
styleUrl: './foliary-card.css',
host: {

@gemini-code-assist gemini-code-assist Bot Jul 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

ChangeDetectionStrategy.Eager is not a valid Angular change detection strategy. Angular only supports Default and OnPush. Using Eager will cause a compilation error. For better performance, it is recommended to use OnPush.

Suggested change
host: {
changeDetection: ChangeDetectionStrategy.OnPush,

class: 'bg-surface text-on-surface border border-outline rounded-xl',
},
})
export class FoliaryCard {
}
export class FoliaryCard {}
17 changes: 8 additions & 9 deletions website/src/app/component/foliary-outlined-button/foliary-outlined-button.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
import { Component } from '@angular/core';

@Component({
selector: 'button[foliary-outlined-button], a[foliary-outlined-button]',
standalone: true,
templateUrl: './foliary-outlined-button.html',
styleUrl: './foliary-outlined-button.css',
host: {
'class': 'bg-transparent text-primary border border-outline rounded-full px-6 py-3 font-medium'
}
selector: 'button[foliary-outlined-button], a[foliary-outlined-button]',
standalone: true,
templateUrl: './foliary-outlined-button.html',
styleUrl: './foliary-outlined-button.css',
host: {

@gemini-code-assist gemini-code-assist Bot Jul 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

ChangeDetectionStrategy.Eager is not a valid Angular change detection strategy. Angular only supports Default and OnPush. Using Eager will cause a compilation error. For better performance, it is recommended to use OnPush.

Suggested change
host: {
changeDetection: ChangeDetectionStrategy.OnPush,

class: 'bg-transparent text-primary border border-outline rounded-full px-6 py-3 font-medium',
},
})
export class FoliaryOutlinedButton {
}
export class FoliaryOutlinedButton {}
17 changes: 8 additions & 9 deletions website/src/app/component/foliary-primary-button/foliary-primary-button.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
import { Component } from '@angular/core';

@Component({
selector: 'button[foliary-primary-button], a[foliary-primary-button]',
standalone: true,
templateUrl: './foliary-primary-button.html',
styleUrl: './foliary-primary-button.css',
host: {
'class': 'bg-primary text-on-primary rounded-full px-6 py-3 font-medium'
}
selector: 'button[foliary-primary-button], a[foliary-primary-button]',
standalone: true,
templateUrl: './foliary-primary-button.html',
styleUrl: './foliary-primary-button.css',
host: {

@gemini-code-assist gemini-code-assist Bot Jul 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

ChangeDetectionStrategy.Eager is not a valid Angular change detection strategy. Angular only supports Default and OnPush. Using Eager will cause a compilation error. For better performance, it is recommended to use OnPush.

Suggested change
host: {
changeDetection: ChangeDetectionStrategy.OnPush,

class: 'bg-primary text-on-primary rounded-full px-6 py-3 font-medium',
},
})
export class FoliaryPrimaryButton {
}
export class FoliaryPrimaryButton {}
17 changes: 8 additions & 9 deletions website/src/app/component/foliary-secondary-button/foliary-secondary-button.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
import { Component } from '@angular/core';

@Component({
selector: 'button[foliary-secondary-button], a[foliary-secondary-button]',
standalone: true,
templateUrl: './foliary-secondary-button.html',
styleUrl: './foliary-secondary-button.css',
host: {
'class': 'bg-secondary-container text-on-secondary-container rounded-full px-6 py-3 font-medium'
}
selector: 'button[foliary-secondary-button], a[foliary-secondary-button]',
standalone: true,
templateUrl: './foliary-secondary-button.html',
styleUrl: './foliary-secondary-button.css',
host: {

@gemini-code-assist gemini-code-assist Bot Jul 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

ChangeDetectionStrategy.Eager is not a valid Angular change detection strategy. Angular only supports Default and OnPush. Using Eager will cause a compilation error. For better performance, it is recommended to use OnPush.

Suggested change
host: {
changeDetection: ChangeDetectionStrategy.OnPush,

class: 'bg-secondary-container text-on-secondary-container rounded-full px-6 py-3 font-medium',
},
})
export class FoliarySecondaryButton {
}
export class FoliarySecondaryButton {}
10 changes: 5 additions & 5 deletions website/src/app/component/footer/footer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ import { Component } from '@angular/core';
import { CommonModule } from '@angular/common';

@Component({
selector: 'app-footer',
standalone: true,
imports: [CommonModule],
templateUrl: './footer.html',
styleUrl: './footer.css'
selector: 'app-footer',
standalone: true,
imports: [CommonModule],
templateUrl: './footer.html',
styleUrl: './footer.css',

@gemini-code-assist gemini-code-assist Bot Jul 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

ChangeDetectionStrategy.Eager is not a valid Angular change detection strategy. Angular only supports Default and OnPush. Using Eager will cause a compilation error. For better performance, it is recommended to use OnPush.

Suggested change
styleUrl: './footer.css',
changeDetection: ChangeDetectionStrategy.OnPush,

})
export class Footer {}
10 changes: 5 additions & 5 deletions website/src/app/component/navigation-bar/navigation-bar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ import { Component } from '@angular/core';
import { CommonModule } from '@angular/common';

@Component({
selector: 'app-navigation-bar',
standalone: true,
imports: [CommonModule],
templateUrl: './navigation-bar.html',
styleUrl: './navigation-bar.css'
selector: 'app-navigation-bar',
standalone: true,
imports: [CommonModule],
templateUrl: './navigation-bar.html',
styleUrl: './navigation-bar.css',

@gemini-code-assist gemini-code-assist Bot Jul 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

ChangeDetectionStrategy.Eager is not a valid Angular change detection strategy. Angular only supports Default and OnPush. Using Eager will cause a compilation error. For better performance, it is recommended to use OnPush.

Suggested change
styleUrl: './navigation-bar.css',
changeDetection: ChangeDetectionStrategy.OnPush,

})
export class NavigationBar {}
13 changes: 5 additions & 8 deletions website/src/app/page/under-construction/under-construction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,10 @@ import { FoliaryCard } from '../../component/foliary-card/foliary-card';
import { FoliaryPrimaryButton } from '../../component/foliary-primary-button/foliary-primary-button';

@Component({
selector: 'app-under-construction',
standalone: true,
imports: [
FoliaryCard,
FoliaryPrimaryButton,
],
templateUrl: './under-construction.html',
styleUrl: './under-construction.css',
selector: 'app-under-construction',
standalone: true,
imports: [FoliaryCard, FoliaryPrimaryButton],
templateUrl: './under-construction.html',
styleUrl: './under-construction.css',

@gemini-code-assist gemini-code-assist Bot Jul 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

ChangeDetectionStrategy.Eager is not a valid Angular change detection strategy. Angular only supports Default and OnPush. Using Eager will cause a compilation error. For better performance, it is recommended to use OnPush.

Suggested change
styleUrl: './under-construction.css',
changeDetection: ChangeDetectionStrategy.OnPush,

})
export class UnderConstruction {}
28 changes: 15 additions & 13 deletions website/tsconfig.app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,19 @@
/* To learn more about Typescript configuration file: https://www.typescriptlang.org/docs/handbook/tsconfig-json.html. */
/* To learn more about Angular compiler options: https://angular.dev/reference/configs/angular-compiler-options. */
{
"extends": "./tsconfig.json",
"compilerOptions": {
"outDir": "./out-tsc/app",
"types": [
"node"
]
},
"include": [
"src/**/*.ts"
],
"exclude": [
"src/**/*.spec.ts"
]
"extends": "./tsconfig.json",
"compilerOptions": {
"outDir": "./out-tsc/app",
"types": ["node"]
},
"include": ["src/**/*.ts"],
"exclude": ["src/**/*.spec.ts"],
"angularCompilerOptions": {
"extendedDiagnostics": {
"checks": {
"nullishCoalescingNotNullable": "suppress",
"optionalChainNotNullable": "suppress"
Comment on lines +14 to +15

@gemini-code-assist gemini-code-assist Bot Jul 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Suppressing nullishCoalescingNotNullable and optionalChainNotNullable diagnostics is discouraged as it hides redundant or useless operators in your templates, which can lead to dead code or misleading type safety assumptions. It is recommended to set these to warning or error to maintain code quality.

Suggested change
"nullishCoalescingNotNullable": "suppress",
"optionalChainNotNullable": "suppress"
"nullishCoalescingNotNullable": "warning",
"optionalChainNotNullable": "warning"

}
}
}
}