feat(ledger): wire ledgerDmk flag to offscreen mode switching#43488
Draft
montelaidev wants to merge 1 commit into
Draft
feat(ledger): wire ledgerDmk flag to offscreen mode switching#43488montelaidev wants to merge 1 commit into
montelaidev wants to merge 1 commit into
Conversation
Add the ledgerDmk remote feature flag constant, UI selector, and CI registry entry. Expose getLedgerMode on the controller and push switchLedgerMode events from the background when the flag changes so the offscreen router can hot-swap handlers at runtime while DMK still delegates to legacy. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (5 files, +382 -3)
|
mm-token-exchange-service
Bot
added
the
INVALID-PR-TEMPLATE
5 tasks
Contributor
Builds ready [48ec59e]
⚡ Performance Benchmarks (Total: 🟢 18 pass · 🟡 4 warn · 🔴 1 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the
ledgerDmkremote feature flag and runtime wiring so the background can tell the offscreen document which Ledger handler mode to use.PR 2 of 3 (stacked on #43487):
Changes:
ENABLE_DMK_FEATURE_FLAGconstant, UI selector, and E2E feature-flag registry entrygetLedgerMode()onMetaMaskController(merges manifest overrides)switchLedgerModelistenForModeSwitches()+ race-condition guards in the routerDMK handler remains a stub delegating to legacy until PR 3.
Changelog Entry
CHANGELOG entry: null
Related Issues
Fixes: N/A
Manual Testing Steps
yarn startoryarn build:test).ledgerDmkdisabled (default), connect a Ledger and verify signing works via legacy..manifest-overrides.json, set"remoteFeatureFlags": { "ledgerDmk": { "enabled": true, "minimumVersion": "<your-version>", "featureVersion": "<your-version>" } }and reload.Pre-merge Author Checklist
Made with Cursor