refactor(enrich/maintainer): split into submodule directory (#57 2/3)#64
Merged
Conversation
src/enrich/maintainer.rs (1284 LOC) -> src/enrich/maintainer/: - types.rs (74): Host, MaintainerAgeFinding, MaintainerInfo, LookupError, GithubResponse, GitlabResponse, constants - pipeline.rs (206): enrich, enrich_with, enrich_with_hosts - github.rs (118): lookup_github_repo, github_get - gitlab.rs (129): lookup_gitlab_repo, gitlab_get - codeberg.rs (19): lookup_codeberg_repo - parsing.rs (286): URL/ISO/percent/JSON/Link-header helpers - tests.rs (421): full #[cfg(test)] block Biggest non-test file: parsing.rs at 286 LOC. Public API unchanged (re-exported via mod.rs). Pure mechanical split, zero behavior change. 429 lib tests pass, clippy clean.
Coverage reportLine coverage: 84.2% (9585 / 11384 lines) Full lcov report available as workflow artifact coverage-lcov: download from this run. v0.9.8 introduces this report; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of 3 for #57 (module size budget round 2). Follows the same pattern as #62 (run.rs split).
What
src/enrich/maintainer.rs(1284 LOC) split intosrc/enrich/maintainer/(8 files):pub usere-exports#[cfg(test)]blockBiggest non-test file: parsing.rs at 286 LOC. Well under the 600 budget.
Behavior change
None. Pure mechanical cut/paste. Public API preserved via
pub usein mod.rs (verifiedpub(crate)helpers likeparse_github_repoandiso8601_to_unix_secondsstill resolve at their old paths).Verification
Follow-up
3/3 of #57: split
src/render/sarif.rs(1205 LOC). Coming next.