Skip to content

Code Quality Fixes#463

Merged
jbouder merged 2 commits intomainfrom
code-qual-fixes
Feb 27, 2026
Merged

Code Quality Fixes#463
jbouder merged 2 commits intomainfrom
code-qual-fixes

Conversation

@jbouder
Copy link
Contributor

@jbouder jbouder commented Feb 27, 2026

Description

  • Fixed malformed ids
  • Removed Redundant conditions

Related Issue

N/A

Motivation and Context

  • Fix Code Quality issues

How Has This Been Tested?

  • Local Testing

Screenshots (if appropriate):

Copilot AI review requested due to automatic review settings February 27, 2026 17:01
@jbouder jbouder added the bug Something isn't working label Feb 27, 2026
@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.59%. Comparing base (f999a5d) to head (ae8a46f).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #463   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files          51       51           
  Lines         995      995           
  Branches      344      344           
=======================================
  Hits          991      991           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses code quality issues by fixing malformed HTML IDs and removing redundant boolean conditions. The changes improve code correctness and readability while maintaining functionality.

Changes:

  • Fixed test IDs to follow kebab-case convention and remove invalid spaces in HTML IDs
  • Removed redundant boolean checks (props.smooth && props.smooth) in three graph components

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/comet-extras/src/components/tabs/tabs.test.tsx Changed ID from "UNIT TEST" (invalid with spaces) to "tabs" (kebab-case) across 5 test cases
packages/comet-data-viz/src/components/stack-graph/stack-graph.tsx Removed redundant condition props.smooth && props.smooth, simplified to props.smooth
packages/comet-data-viz/src/components/line-graph/line-graph.tsx Removed redundant condition props.smooth && props.smooth, simplified to props.smooth
packages/comet-data-viz/src/components/area-graph/area-graph.tsx Removed redundant condition props.smooth && props.smooth, simplified to props.smooth

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jbouder jbouder merged commit 53a984e into main Feb 27, 2026
14 checks passed
@jbouder jbouder deleted the code-qual-fixes branch February 27, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants