Skip to content

Code Quality Fixes #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbouder merged 2 commits into from
Feb 27, 2026
Merged

Code Quality Fixes #463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1647a0
Fix malformed ids on tests.
Feb 27, 2026
ae8a46f
Remove redundant condition.
Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/comet-data-viz/src/components/area-graph/area-graph.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const AreaGraph: React.FC<AreaGraphProps> = (props: AreaGraphProps) => {
},
}}
data={d}
interpolation={props.smooth && props.smooth ? 'natural' : undefined}
interpolation={props.smooth ? 'natural' : undefined}
animate={{
duration: 2000,
onLoad: { duration: 1000 },
Expand Down
2 changes: 1 addition & 1 deletion packages/comet-data-viz/src/components/line-graph/line-graph.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ const LineGraph: React.FC<LineGraphProps> = (props: LineGraphProps) => {
duration: 2000,
onLoad: { duration: 1000 },
}}
interpolation={props.smooth && props.smooth ? 'natural' : undefined}
interpolation={props.smooth ? 'natural' : undefined}
/>
))}
</VictoryChart>
Expand Down
2 changes: 1 addition & 1 deletion packages/comet-data-viz/src/components/stack-graph/stack-graph.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const StackGraph: React.FC<StackGraphProps> = (props: StackGraphProps) => {
},
}}
data={d}
interpolation={props.smooth && props.smooth ? 'natural' : undefined}
interpolation={props.smooth ? 'natural' : undefined}
animate={{
duration: 2000,
onLoad: { duration: 1000 },
Expand Down
10 changes: 5 additions & 5 deletions packages/comet-extras/src/components/tabs/tabs.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import Tabs, { TabPanel } from './tabs';
describe('Tabs', () => {
test('should render a tabs component successfully', () => {
const { baseElement } = render(
<Tabs id="UNIT TEST" defaultTabId="1">
<Tabs id="tabs" defaultTabId="1">
<TabPanel id="1" label="UNIT TEST 1">
UNIT TEST 1
</TabPanel>
Expand All @@ -20,7 +20,7 @@ describe('Tabs', () => {

test('should have correct class for active tab', () => {
const { baseElement } = render(
<Tabs id="UNIT TEST" defaultTabId="1">
<Tabs id="tabs" defaultTabId="1">
<TabPanel id="1" label="UNIT TEST LABEL 1">
UNIT TEST 1
</TabPanel>
Expand All @@ -36,7 +36,7 @@ describe('Tabs', () => {

test('should have correct class for inactive tab', () => {
const { baseElement } = render(
<Tabs id="UNIT TEST" defaultTabId="2">
<Tabs id="tabs" defaultTabId="2">
<TabPanel id="1" label="UNIT TEST 1">
UNIT TEST 1
</TabPanel>
Expand All @@ -52,7 +52,7 @@ describe('Tabs', () => {

test('should contain correct class name when provided as a prop', () => {
const { baseElement } = render(
<Tabs id="UNIT TEST" defaultTabId="1" className="UNIT-TEST-CLASS">
<Tabs id="tabs" defaultTabId="1" className="UNIT-TEST-CLASS">
<TabPanel id="1" label="UNIT TEST LABEL 1">
UNIT TEST 1
</TabPanel>
Expand All @@ -68,7 +68,7 @@ describe('Tabs', () => {

test('should apply correct class names when user clicks on a tab', () => {
render(
<Tabs id="UNIT TEST" defaultTabId="2">
<Tabs id="tabs" defaultTabId="2">
<TabPanel id="1" label="UNIT TEST LABEL 1">
UNIT TEST 1
</TabPanel>
Expand Down