Bump pinned MEOS to include the wasm pg_config fix#142
Closed
estebanzimanyi wants to merge 1 commit into
Closed
Conversation
This was referenced May 16, 2026
Member
Author
Reviewer's quickstart — ~2 minutesWhat this PR does: Bump pinned MEOS to include the wasm pg_config fix. Files to read: Risk: narrow scope; the diff is small and self-contained. Stacked on its base PR — once the stack ahead of it lands, this rebases trivially. Cross-link: Linux arm64 CI needs #161 for the |
Adds the SIZEOF_LONG_LONG emission to the rendered pg_config.h so the DuckDB-Wasm (wasm32-emscripten / ILP32) build of MEOS no longer fails the pg_bitutils integer-width check.
estebanzimanyi
force-pushed
the
fix/bump-meos-pin-wasm-pgconfig
branch
from
8d63247 to
fa2de57
Compare
estebanzimanyi
changed the base branch from
fix/stage-icu-macos-platform
to
fix/macos-int64-bigint-to-set-forwarder
Member
Author
|
Folded into #134: the MEOS pin bump and the changes that keep CI green (graceful icu degradation + stage_icu, per-thread MEOS init, deterministic ln/exp/log10, macOS int64 forwarder, wasm pg_config) are jointly required for the extension to build, load, and pass — they ship as one foundation PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MobilityDuck builds MEOS from a pinned MobilityDB commit; the current pin predates the fix that emits SIZEOF_LONG_LONG, so the DuckDB-Wasm jobs fail in the vendored postgres pg_bitutils.h on wasm32. This advances the pin to a MobilityDB commit that carries that fix (MobilityDB PR #1036). It is provisionally pointed at estebanzimanyi/MobilityDB@40145502c because #1036 is not yet on MobilityDB/MobilityDB master, kept as a Draft for that reason; the landable form points REPO back to MobilityDB/MobilityDB at the post-merge master commit with SHA512 recomputed from that archive. Stacked on fix/stage-icu-macos-platform (#141); its commits show in this diff until it merges.