Fix/remove unused parameter merge order levels#201
Merged
Conversation
The _new parameter was actively used in the function body but named with a leading underscore, which conventionally signals an intentionally unused parameter. This was misleading and violated the noUnusedParameters TypeScript rule intent. Renamed _new to updates to accurately reflect its role: applying incremental order book level changes on top of the existing state. Closes #154
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: mergeOrderLevels had its second parameter named _new. In TypeScript, prefixing a parameter with _ is a convention to tell the compiler "I know this is unused, suppress the warning." But the parameter was actually used — _new.forEach(...) iterates over it to apply delta updates to the order book map. The name was both misleading and a violation of the noUnusedParameters rule's intent.
Fix: Renamed _new → updates, which accurately describes what the parameter represents: the incoming order book level changes being merged into the existing state.
Closes #154