Skip to content

Fix/remove unused parameter merge order levels #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mosas2000 merged 6 commits into from
May 21, 2026
Merged

Fix/remove unused parameter merge order levels #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bd6d317
replace any[] with unknown[] in validateTransactions parameter
Mosas2000 May 21, 2026
6393e43
replace any[] with unknown[] in validatePositions parameter
Mosas2000 May 21, 2026
3193446
replace any with unknown in validatePortfolio parameter
Mosas2000 May 21, 2026
9878fdb
replace any[] with unknown[] in validateRewards parameter
Mosas2000 May 21, 2026
21307a3
replace any with unknown in getValidationErrors data parameter
Mosas2000 May 21, 2026
32a9bdb
fix: rename _new to updates in mergeOrderLevels
Mosas2000 May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions frontend/src/utils/exportValidator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { ExportTransaction, ExportPosition, ExportPortfolio, ExportReward } from '../types/export';

export class ExportValidator {
static validateTransactions(transactions: any[]): transactions is ExportTransaction[] {
static validateTransactions(transactions: unknown[]): transactions is ExportTransaction[] {
if (!Array.isArray(transactions)) return false;

return transactions.every(t =>
Expand All @@ -15,7 +15,7 @@ export class ExportValidator {
);
}

static validatePositions(positions: any[]): positions is ExportPosition[] {
static validatePositions(positions: unknown[]): positions is ExportPosition[] {
if (!Array.isArray(positions)) return false;

return positions.every(p =>
Expand All @@ -30,7 +30,7 @@ export class ExportValidator {
);
}

static validatePortfolio(portfolio: any): portfolio is ExportPortfolio {
static validatePortfolio(portfolio: unknown): portfolio is ExportPortfolio {
return (
typeof portfolio.totalValue === 'number' &&
typeof portfolio.totalInvested === 'number' &&
Expand All @@ -42,7 +42,7 @@ export class ExportValidator {
);
}

static validateRewards(rewards: any[]): rewards is ExportReward[] {
static validateRewards(rewards: unknown[]): rewards is ExportReward[] {
if (!Array.isArray(rewards)) return false;

return rewards.every(r =>
Expand Down Expand Up @@ -78,7 +78,7 @@ export class ExportValidator {
return year >= 1900 && year <= currentYear;
}

static getValidationErrors(data: any, type: string): string[] {
static getValidationErrors(data: unknown, type: string): string[] {
const errors: string[] = [];

switch (type) {
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/utils/websocketUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,14 +262,14 @@ export function mergeOrderBooks(oldBook: OrderBookUpdate, newBook: OrderBookUpda
};
}

function mergeOrderLevels(old: Array<{ price: number; amount: number }>, _new: Array<{ price: number; amount: number }>): Array<{ price: number; amount: number }> {
function mergeOrderLevels(old: Array<{ price: number; amount: number }>, updates: Array<{ price: number; amount: number }>): Array<{ price: number; amount: number }> {
const map = new Map<number, number>();

old.forEach(({ price, amount }) => {
map.set(price, amount);
});

_new.forEach(({ price, amount }) => {
updates.forEach(({ price, amount }) => {
if (amount === 0) {
map.delete(price);
} else {
Expand Down
Loading