fix urban restart, allocation variables issue and units of evaporation for imp_scheme==2 in slucm#320
fix urban restart, allocation variables issue and units of evaporation for imp_scheme==2 in slucm#320tslin2 wants to merge 4 commits intoNCAR:developfrom
Conversation
cenlinhe
requested review from
CharlesZheZhang,
RAbolafiaRosenzweig and
cenlinhe
cenlinhe
left a comment
cenlinhe
left a comment
There was a problem hiding this comment.
This PR with a few bug fixes for urban dimensions in restart file and urban flux unit look good.
|
A quick question: I saw you also have changes in noahmp part in this PR. However, the noahmp PR you submitted to the noahmp GitHub repo has not been merged to the official noahmp develop branch yet. In that case, what is the noahmp change associated with this PR submitted here? |
the noahmp submit module is the same as NCAR/noahmp#243 Otherwise, the model cannot be run. I am not sure if I submit here can also update noahmp github or not or is just the link to noahmp submodule |
|
OK, I see. The noahmp part here cannot update noahmp github. It is probably just a link to the noahmp repo commit. |
|
@CharlesZheZhang @RAbolafiaRosenzweig Could you please take a look and approve it? This is a critical bug fix that we need to merge to the main branch quickly. |
2 participants
Fix units of evaporation for imp_scheme==2 in slucm #308
Fix Missing urban layer of "UNDM" in the restart file #319
Link to NohaMP submodule NCAR/noahmp#243
Tests perform, working fine for all SF_URBAN_PHYSICS option using HRLDAS for initial and restart runs