Urban fix for urban physics variables allocation and default urban vertical resolution for BEP#243
Open
tslin2 wants to merge 2 commits intoNCAR:developfrom
Open
Urban fix for urban physics variables allocation and default urban vertical resolution for BEP#243tslin2 wants to merge 2 commits intoNCAR:developfrom
tslin2 wants to merge 2 commits intoNCAR:developfrom
Conversation
cenlinhe
requested review from
CharlesZheZhang,
RAbolafiaRosenzweig and
cenlinhe
Collaborator
|
The urban dimension restart issue fix is in hrldas github: NCAR/hrldas#320 |
cenlinhe
approved these changes
Apr 10, 2026
Collaborator
cenlinhe
left a comment
cenlinhe
left a comment
There was a problem hiding this comment.
This PR is to fix the urban variable allocation issue for different urban options (i.e., isolate the shared urban physics from the specific urban physics option if-statement). The PR looks good and the developer's tests were successful.
Collaborator
|
@CharlesZheZhang @RAbolafiaRosenzweig Could you please take a look and approve it? This is a critical bug fix that we need to merge to the main branch quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix the issue and PR #241
Also change the default urban_atmosphere_thickness in the namelist to match the default in BEP and BEP-BEM
Tests perform, working fine for all SF_URBAN_PHYSICS option using HRLDAS