Skip to content

Mdeshotel 9712 forcing input mod2#128

Open
mdeshotel wants to merge 32 commits intomdeshotel_pre_devfrom
mdeshotel-9712_forcingInputMod2
Open

Mdeshotel 9712 forcing input mod2#128
mdeshotel wants to merge 32 commits intomdeshotel_pre_devfrom
mdeshotel-9712_forcingInputMod2

Conversation

@mdeshotel
Copy link

This is the second PR for InputForcings. It primarily splits Input Forcing into 3 children classes based on discretization type (gridded, hydrofabric, or unstructured). I also handles bug fixes that were identified when running tests between the pre-refactored and post-refactored GeoMod and InputForcings classes.

Additions

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant