Skip to content

Mdeshotel 9712 forcing input mod2 #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdeshotel wants to merge 32 commits into
base: mdeshotel_pre_dev
Choose a base branch
from
+3,085 −2,991
Open

Mdeshotel 9712 forcing input mod2 #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
0f1554b
update imports
mdeshotel Feb 13, 2026
1893375
add consts.py
mdeshotel Feb 13, 2026
32c9446
split GeoMeta class into a base class and children classes
mdeshotel Feb 13, 2026
a3c9487
perform check before initializing GeoMeta
mdeshotel Feb 17, 2026
ab19b1b
add type hints and correctly handle new properties/attributes
mdeshotel Feb 17, 2026
5b9dac4
assume bounds are float instead of int
mdeshotel Feb 17, 2026
472936b
fix malformed function calls for slopes
mdeshotel Feb 18, 2026
1246c6e
linting
mdeshotel Feb 18, 2026
ccc84a3
modularize the classes in geoMod.py
mdeshotel Feb 22, 2026
f39fb41
fix property decorators
mdeshotel Feb 22, 2026
47e37a8
move intialization of InputForcings to its __ini__.
mdeshotel Feb 23, 2026
b3a96dc
move static dictionaries to conts.py
mdeshotel Feb 23, 2026
c3f1099
add type hints
mdeshotel Feb 23, 2026
e6e8922
move conditionals to geoMod.py
mdeshotel Feb 23, 2026
0877b2a
update type hint
mdeshotel Feb 23, 2026
542aa3e
rename variables for better consistency across the repo
mdeshotel Feb 24, 2026
d78a7a4
update variable names to be consistent across the repo
mdeshotel Feb 24, 2026
259632a
split bmi model into multiple classes based on specified discretization
mdeshotel Feb 24, 2026
832534d
remove commented out items
mdeshotel Feb 24, 2026
965dcd5
split input forcing into multiple classes based on specified discreti…
mdeshotel Feb 24, 2026
a9546e0
update variable names across the repo
mdeshotel Feb 25, 2026
cacbe50
resolve circular imports
mdeshotel Feb 25, 2026
b10ce67
get grid type before initializing
mdeshotel Feb 25, 2026
8545a65
make parse_config a function instead of a method
mdeshotel Feb 25, 2026
bdce41e
rename geo_meta and move init logic out of the __init__ method
mdeshotel Feb 25, 2026
b9142ef
move bmi_model conts to the bmi_model dict
mdeshotel Feb 25, 2026
130a024
fix method calls and reference base class for consts
mdeshotel Feb 25, 2026
3e42cef
refactor bugs 1
mdeshotel Mar 20, 2026
fc69fba
dynamically manage discretization-specific GeoMeta classes
mdeshotel Mar 24, 2026
7f29a3e
fix geomod bugs
mdeshotel Mar 24, 2026
acb7ad7
add additional constants for mapping old to new variable names
mdeshotel Mar 24, 2026
d6ca3fa
fix bugs in forcingInputMod
mdeshotel Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,051 changes: 387 additions & 664 deletions NextGen_Forcings_Engine_BMI/NextGen_Forcings_Engine/bmi_model.py
View file
Open in desktop

Large diffs are not rendered by default.

14 changes: 7 additions & 7 deletions NextGen_Forcings_Engine_BMI/NextGen_Forcings_Engine/core/bias_correction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def run_bias_correction(input_forcings, config_options, geo_meta_wrf_hydro, mpi_
3: ncar_temp_gfs_bias_correct,
4: ncar_temp_hrrr_bias_correct,
}
bias_correct_temperature[input_forcings.t2dBiasCorrectOpt](
bias_correct_temperature[input_forcings.t2BiasCorrectOpt](
input_forcings, config_options, mpi_config, 0
)
err_handler.check_program_status(config_options, mpi_config)
Expand All @@ -65,7 +65,7 @@ def run_bias_correction(input_forcings, config_options, geo_meta_wrf_hydro, mpi_
1: cfsv2_nldas_nwm_bias_correct,
2: ncar_tbl_correction,
}
bias_correct_humidity[input_forcings.q2dBiasCorrectOpt](
bias_correct_humidity[input_forcings.q2BiasCorrectOpt](
input_forcings, config_options, mpi_config, 1
)
err_handler.check_program_status(config_options, mpi_config)
Expand Down Expand Up @@ -114,12 +114,12 @@ def run_bias_correction(input_forcings, config_options, geo_meta_wrf_hydro, mpi_
4: ncar_wspd_hrrr_bias_correct,
}
# Run for U-Wind
bias_correct_wind[input_forcings.windBiasCorrectOpt](
bias_correct_wind[input_forcings.windBiasCorrect](
input_forcings, config_options, mpi_config, 2
)
err_handler.check_program_status(config_options, mpi_config)
# Run for V-Wind
bias_correct_wind[input_forcings.windBiasCorrectOpt](
bias_correct_wind[input_forcings.windBiasCorrect](
input_forcings, config_options, mpi_config, 3
)
err_handler.check_program_status(config_options, mpi_config)
Expand Down Expand Up @@ -2473,7 +2473,7 @@ def cfsv2_nldas_nwm_bias_correct(input_forcings, config_options, mpi_config, for
id_nldas_param = nldas_param_file = None
if mpi_config.rank == 0:
nldas_param_file = (
input_forcings.paramDir
input_forcings.dScaleParamDirs
+ "/NLDAS_Climo/nldas2_"
+ config_options.current_output_date.strftime("%m%d%H")
+ "_dist_params.nc"
Expand Down Expand Up @@ -2700,7 +2700,7 @@ def cfsv2_nldas_nwm_bias_correct(input_forcings, config_options, mpi_config, for
if mpi_config.rank == 0:
# Read in the CFSv2 parameter files, based on the previous CFSv2 dates
cfs_param_path1 = (
input_forcings.paramDir
input_forcings.dScaleParamDirs
+ "/CFSv2_Climo/cfs_"
+ cfs_param_path_vars[force_num]
+ "_"
Expand All @@ -2711,7 +2711,7 @@ def cfsv2_nldas_nwm_bias_correct(input_forcings, config_options, mpi_config, for
)

cfs_param_path2 = (
input_forcings.paramDir
input_forcings.dScaleParamDirs
+ "/CFSv2_Climo/cfs_"
+ cfs_param_path_vars[force_num]
+ "_"
Expand Down
Loading