Fix export of fp8 ONNX files#52
Merged
Merged
Conversation
Signed-off-by: Ben Howe <bhowe@nvidia.com>
`_collect_calibration_dets` returns uint8; casting to float32 before
passing to mq.quantize triggered an INVALID_ARGUMENT error from the
ONNX runtime ("expected: tensor(uint8), got: tensor(float)").
The new test mirrors the existing int8 variant and asserts that the
fp8 path preserves the original uint8 dtype and forwards the
FP8-specific kwargs (op_types_to_quantize, high_precision_dtype).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Apr 8, 2026
ivanbasov
added a commit
that referenced
this pull request
Apr 10, 2026
* Fix export of fp8 ONNX files Signed-off-by: Ben Howe <bhowe@nvidia.com> * test: add fp8 calibration dtype regression test for #52 `_collect_calibration_dets` returns uint8; casting to float32 before passing to mq.quantize triggered an INVALID_ARGUMENT error from the ONNX runtime ("expected: tensor(uint8), got: tensor(float)"). The new test mirrors the existing int8 variant and asserts that the fp8 path preserves the original uint8 dtype and forwards the FP8-specific kwargs (op_types_to_quantize, high_precision_dtype). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Signed-off-by: Ben Howe <bhowe@nvidia.com> Co-authored-by: Ivan Basov <ibasov@nvidia.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change:
With this change, no such error is produced. Now we can properly export fp8 ONNX files.