fix(test): enable Relay for Hermes streaming coverage - #136
Merged
rapids-bot[bot] merged 1 commit intoJul 28, 2026
Merged
Conversation
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
WalkthroughThe Python test target now installs the Hermes agent extra. The persistent-host Hermes E2E test enables the relay fixture and initializes Hermes with relay configuration. ChangesHermes relay testing
Estimated code review effort: 2 (Simple) | ~8 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Fern docs preview: https://nvidia-preview-pull-request-136.docs.buildwithfern.com/nemo/fabric |
AjayThorve
approved these changes
Jul 28, 2026
AjayThorve
left a comment
Collaborator
There was a problem hiding this comment.
verified it fixes the problematic hermes e2e test
Contributor
Author
|
/merge |
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Enable NeMo Relay for the Hermes persistent-runtime streaming test and keep Hermes Agent installed when the CI-equivalent Python test recipe synchronizes its environment. This ensures the streaming assertions execute instead of failing the Relay precondition or skipping because the optional harness dependency was removed.
This changes test and CI-recipe behavior only. There are no public API, runtime behavior, dependency-version, or breaking changes.
Details
with_relay(...)and require thenemo_relayfixture.hermes-agentextra injust test-pythonso the recipe preserves the harness dependency installed by Python CI.streaming=Truewithout Relay unchanged.Validation
uv run --no-sync pytest tests/e2e/test_hermes_e2e.py::test_hermes_persistent_host_reuses_native_session -vv -rs— 1 passeduv run --no-sync pytest tests/python/test_streaming.py tests/e2e/test_hermes_e2e.py -q -rs— 40 passedjust test-python— 501 passed, 15 unrelated opt-in integration tests skipped; all five Hermes E2E tests executedjust --fmt --checkgit diff --checkWhere should the reviewer start?
Start with
tests/e2e/test_hermes_e2e.py::test_hermes_persistent_host_reuses_native_session, then review the optional extras in thejustfiletest-pythonrecipe.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Relates to feat: add Relay-backed runtime streaming #109 and refactor: slim adapter runtime dependencies #105
I confirm this contribution is my own work, or I have the right to submit it under this project's license.
I searched existing issues and open pull requests, and this does not duplicate existing work.
Summary by CodeRabbit