Skip to content

fix(test): enable Relay for Hermes streaming coverage - #136

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:release/0.1from
yczhang-nv:fix/hermes-streaming-tests
Jul 28, 2026
Merged

fix(test): enable Relay for Hermes streaming coverage#136
rapids-bot[bot] merged 1 commit into
NVIDIA:release/0.1from
yczhang-nv:fix/hermes-streaming-tests

Conversation

@yczhang-nv

@yczhang-nv yczhang-nv commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Overview

Enable NeMo Relay for the Hermes persistent-runtime streaming test and keep Hermes Agent installed when the CI-equivalent Python test recipe synchronizes its environment. This ensures the streaming assertions execute instead of failing the Relay precondition or skipping because the optional harness dependency was removed.

This changes test and CI-recipe behavior only. There are no public API, runtime behavior, dependency-version, or breaking changes.

Details

  • Build the Hermes streaming test configuration with with_relay(...) and require the nemo_relay fixture.
  • Include the hermes-agent extra in just test-python so the recipe preserves the harness dependency installed by Python CI.
  • Leave the intentional negative unit test for streaming=True without Relay unchanged.

Validation

  • uv run --no-sync pytest tests/e2e/test_hermes_e2e.py::test_hermes_persistent_host_reuses_native_session -vv -rs — 1 passed
  • uv run --no-sync pytest tests/python/test_streaming.py tests/e2e/test_hermes_e2e.py -q -rs — 40 passed
  • just test-python — 501 passed, 15 unrelated opt-in integration tests skipped; all five Hermes E2E tests executed
  • just --fmt --check
  • git diff --check

Where should the reviewer start?

Start with tests/e2e/test_hermes_e2e.py::test_hermes_persistent_host_reuses_native_session, then review the optional extras in the justfile test-python recipe.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

Summary by CodeRabbit

  • Tests
    • Improved end-to-end coverage for persistent host sessions using relay-enabled runtime configurations.
    • Updated Python test setup to include the optional dependencies required for Hermes agent testing.
    • Enhanced validation of native session reuse behavior.

Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
@yczhang-nv
yczhang-nv requested a review from a team as a code owner July 28, 2026 16:53
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The Python test target now installs the Hermes agent extra. The persistent-host Hermes E2E test enables the relay fixture and initializes Hermes with relay configuration.

Changes

Hermes relay testing

Layer / File(s) Summary
Hermes test dependencies
justfile
The test-python target synchronizes the hermes-agent optional dependency group.
Relay-enabled Hermes test
tests/e2e/test_hermes_e2e.py
The persistent-host test enables nemo_relay and initializes Hermes configuration with relay support.

Estimated code review effort: 2 (Simple) | ~8 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title follows Conventional Commits and accurately summarizes the Relay-related test/CI update.
Description check ✅ Passed The description covers overview, reviewer start, related issues, validation, and required confirmations.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@yczhang-nv yczhang-nv self-assigned this Jul 28, 2026
@yczhang-nv yczhang-nv changed the title test: enable Relay for Hermes streaming coverage fix(test): enable Relay for Hermes streaming coverage Jul 28, 2026
@github-actions

Copy link
Copy Markdown

@AjayThorve AjayThorve left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified it fixes the problematic hermes e2e test

@yczhang-nv

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 597a07f into NVIDIA:release/0.1 Jul 28, 2026
31 checks passed
@yczhang-nv
yczhang-nv deleted the fix/hermes-streaming-tests branch July 28, 2026 17:44
@coderabbitai coderabbitai Bot mentioned this pull request Jul 28, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants