[None][fix] handle broken symlinks in build_wheel.py install_file#13027
Open
zhenhuaw-me wants to merge 1 commit intoNVIDIA:mainfrom
Open
[None][fix] handle broken symlinks in build_wheel.py install_file#13027zhenhuaw-me wants to merge 1 commit intoNVIDIA:mainfrom
zhenhuaw-me wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
shutil.copy fails with FileNotFoundError when the destination is a broken symlink (e.g., left by a previous `pip install -e` whose build/lib.* directory was later cleaned). Remove broken symlinks at the destination before copying, matching the existing behavior of the symlink_remove_dst path. Signed-off-by: Zhenhua Wang <zhenhuaw@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe wheel building script's file copy operation is enhanced with a new wrapper function that explicitly handles broken symlinks by removing them before attempting to copy files. This improves the robustness of the installation process when symlink cleanup is necessary. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shutil.copy fails with FileNotFoundError when the destination is a broken symlink (e.g., left by a previous
pip install -ewhose build/lib.* directory was later cleaned). Remove broken symlinks at the destination before copying, matching the existing behavior of the symlink_remove_dst path.Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.