Skip to content

[None][fix] handle broken symlinks in build_wheel.py install_file #13027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhenhuaw-me wants to merge 2 commits into from
+10 −1
Closed

[None][fix] handle broken symlinks in build_wheel.py install_file #13027

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41897c7
[None][fix] handle broken symlinks in build_wheel.py install_file
zhenhuaw-me Apr 14, 2026
9c82dcf
Merge branch 'main' into fix-build
zhenhuaw-me Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion scripts/build_wheel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,16 @@ def main(*,
if cache_dir.exists():
clear_folder(cache_dir)

install_file = copy
def copy_remove_broken_symlink(src, dst):
"""copy() that handles broken symlinks at the destination."""
dst = os.fspath(dst)
if os.path.isdir(dst):
dst = os.path.join(dst, os.path.basename(src))
if os.path.islink(dst) and not os.path.exists(dst):
os.remove(dst)
copy(src, dst)

install_file = copy_remove_broken_symlink

# Wrapper for copytree that checks if source and destination are the same
def safe_copytree(src, dst, dirs_exist_ok=True):
Copy link
Copy Markdown
Member

@tongyuantongyu tongyuantongyu Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this safe_copytree handle the use case you mentioned correctly?

Expand Down
Loading