Conversation
Aurige
reviewed
May 14, 2025
Contributor
Aurige
left a comment
Aurige
left a comment
There was a problem hiding this comment.
I just did a quick walk through and a few comments ... it's a nice improvement but difficult to check that no inheritance or substitution group was forgotten. Was this generated automatically ?
| </xsd:sequence> | ||
| <xsd:attribute name="id" type="TypeOfOperationIdType"/> | ||
| <xsd:attribute name="nameOfClassifiedEntityClass" type="NameOfClass" use="optional" fixed="Operation"> | ||
| <xsd:attribute name="nameOfClassifiedEntityClass" type="NameOfClass" use="optional"> |
Contributor
There was a problem hiding this comment.
what is the purpose for removing the fixed="Operation" ?
Also why only on TypeOfOperation (the same pattern is in all TypeOfEntity_VersionStructure inherited structure...) ?
| <xsd:enumeration value="RoutingConstraintZone"/> | ||
| <xsd:enumeration value="StopArea"/> | ||
| <xsd:enumeration value="TariffZone"/> | ||
| <xsd:enumeration value="TariffZoneRef_"/> |
Contributor
There was a problem hiding this comment.
TariffZoneRef_ is a substitution group (this happens multiple times, just pointing it her for the example)
Collaborator
|
Must be regenerated taking into account the "_" for the Dummy types. |
Closed
Contributor
Author
|
Implemented in #962 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement #806
Uncovers issues related to #862