perf(render): migrate ModerationQueuePage to the selector store - #431
Conversation
|
Warning Review limit reached
Next review available in: 59 minutes Limit details: You’ve used all 1 included review currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthrough
ChangesModeration store migration
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The page now subscribes only to the data slices it uses, reducing unrelated re-renders without a supplied correctness or production-impact concern; no actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@CodeRabbit review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Data slices (students, studentRubrics, rubrics, peerReviews, settings) now come from one useStoreSelector and grading actions from the stable useStoreActions context; only usePlatform remains for fetchSchoolMembers. The admin a11y suite previously let the page's render crash be swallowed by the router error boundary, so it now routes selectors/actions through its shared mocked app value and genuinely renders the page. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
…ionQueuePage The roster domain hooks filtered soft-deleted rows; the selector-store migration read raw slices. Restore the active-student / active-rubric filtering so archived students and deleted student rubrics don't surface in the moderation queue. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
07c816e to
18dc76e
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
|
@CodeRabbit review |
|
1 participant
What
Migrates
ModerationQueuePagefrom six whole-domain hooks to oneuseStoreSelectorfor its five data slices (students,studentRubrics,rubrics,peerReviews,settings) plususeStoreActionsforsaveStudentRubric/deletePeerReview.usePlatformstays only forfetchSchoolMembers(not a store action).Why
Whole-domain subscriptions re-rendered the page on every unrelated collection update; it now re-renders only when its actual slices change.
Notes
usePlatform).pages.admin.a11y.test.tsx: the router error boundary swallowed the page's render crash, so the suite never actually rendered the page. The suite'sbasemock moved to module scope and selectors/actions now route through it.Stacked on #430 (part of the roadmap "Up Next" selector-store series).