π Fix XSS in HTML rendering by escaping markdown content#6
Conversation
Use `_escape` to sanitize user inputs like attack prompts, target responses, and reasonings before rendering them with `st.write` in Streamlit. This prevents markdown injection and XSS vulnerabilities. Co-authored-by: Nevern1y <77607229+Nevern1y@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π― What: Fixed an XSS vulnerability where user inputs like attack prompts, target responses, and reasonings were not being escaped when rendered via Streamlit's
β οΈ Risk: Streamlit's
st.write.st.writecan interpret markdown elements like links or images, which could potentially be abused by a malicious actor injecting markdown, leading to Cross-Site Scripting (XSS) if unsanitized data is provided.π‘οΈ Solution: Wrapped all rendering of user-provided markdown content (e.g.,
case.attack.prompt,verdict.target_response,verdict.reasoning) with the local_escapehelper function to sanitize inputs across_render_worst_case_dossier,_render_case_expanders, and_render_target_drilldown.PR created automatically by Jules for task 1537172274988476768 started by @Nevern1y