Skip to content

🔒 Fix XSS in HTML rendering by escaping markdown content #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nevern1y wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🔒 Fix XSS in HTML rendering by escaping markdown content #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,11 +578,11 @@ def _render_worst_case_dossier(result: EvalResult) -> None:
unsafe_allow_html=True,
)
st.markdown("**Gemma attack**")
st.write(case.attack.prompt)
st.write(_escape(case.attack.prompt))
st.markdown("**Target response**")
st.write(verdict.target_response)
st.write(_escape(verdict.target_response))
st.markdown("**Gemma judge**")
st.write(verdict.reasoning)
st.write(_escape(verdict.reasoning))
if verdict.evidence_span:
st.markdown(
f'<div class="gj-evidence"><strong>Evidence span:</strong> '
Expand All @@ -608,12 +608,12 @@ def _render_case_expanders(result: EvalResult) -> None:
f"{item.attack.id} · score {verdict.score}/5 · {label} · {item.attack.prompt[:82]}"
):
st.markdown("**Gemma attack**")
st.write(item.attack.prompt)
st.write(_escape(item.attack.prompt))
st.caption(f"Rationale: {item.attack.rationale}")
st.markdown("**Target response**")
st.write(verdict.target_response)
st.write(_escape(verdict.target_response))
st.markdown("**Gemma judge**")
st.write(verdict.reasoning)
st.write(_escape(verdict.reasoning))
if verdict.evidence_span:
st.markdown(f"**Evidence span:** `{verdict.evidence_span}`")

Expand All @@ -628,11 +628,11 @@ def _render_target_drilldown(board: LeaderboardResult, target: TargetReport) ->
f"{item.attack.id} · score {verdict.score}/5 · {label} · {item.attack.prompt[:82]}"
):
st.markdown("**Shared Gemma attack**")
st.write(item.attack.prompt)
st.write(_escape(item.attack.prompt))
st.markdown("**Target response**")
st.write(verdict.target_response)
st.write(_escape(verdict.target_response))
st.markdown("**Gemma judge**")
st.write(verdict.reasoning)
st.write(_escape(verdict.reasoning))
if verdict.evidence_span:
st.markdown(f"**Evidence span:** `{verdict.evidence_span}`")

Expand Down
Loading