anki-sync-server: init at 2.1.66#261166
Merged
Merged
Conversation
12 tasks
ofborg
Bot
added
10.rebuild-darwin: 1-10
paveloom
reviewed
Oct 15, 2023
paveloom
reviewed
Oct 15, 2023
Member
paveloom
left a comment
paveloom
left a comment
There was a problem hiding this comment.
About updating Anki: I'd prefer to wait for a new stable release.
Member
Author
|
Thanks for the prompt review!
Yes, that's what I suggested (in an edit, sorry if you checked the mail) -- this package already works in 2.1.66, just not with "newer clients", we can update it when 23.10 is out. |
martinetd
force-pushed
the
anki-sync-server
branch
2 times, most recently
from
b0e24c1 to
dd04eff
Compare
paveloom
approved these changes
Oct 15, 2023
delroth
added
the
12.approvals: 1
h7x4
reviewed
Oct 16, 2023
martinetd
force-pushed
the
anki-sync-server
branch
from
97aeaf1 to
d2a0c6e
Compare
martinetd
commented
Oct 16, 2023
martinetd
force-pushed
the
anki-sync-server
branch
from
d2a0c6e to
3b20f60
Compare
h7x4
approved these changes
Oct 16, 2023
delroth
added
12.approvals: 2
martinetd
force-pushed
the
anki-sync-server
branch
from
3b20f60 to
3a37997
Compare
delroth
removed
the
12.approvals: 1
delroth
removed
the
12.approvals: 1
12 tasks
6 tasks
wegank
force-pushed
the
anki-sync-server
branch
from
3a37997 to
32cd53a
Compare
anki-sync-server will be used in new ankisyncd module. anki itself was slightly modified to add its cargoLock as passthru so we can use it for anki-sync-server as it's built from the same sources. Link: NixOS#257692 Co-authored-by: Pavel Sobolev <paveloom@riseup.net> Co-authored-by: h7x4 <h7x4@nani.wtf>
wegank
force-pushed
the
anki-sync-server
branch
from
32cd53a to
c305510
Compare
Member
|
@ofborg build anki-sync-server anki-sync-server.passthru.tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
anki-sync-server will be used in new ankisyncd module (see #257692)
anki itself was slightly modified to add its cargoLock as passthru so we
can use it for anki-sync-server as it's built from the same sources.
Cc @euank @oxij @paveloom (anki maintainers): I also have an update for anki to 23.10beta6 lined up in https://github.com/martinetd/nixpkgs/commits/anki-sync-server-nixos as they broke the protocol, so will want to update the server as soon as possible. I don't think we should upgrade anki to a beta yet but it might be worth testing; I've only checked it builds and sync appears to work calling the python internal functions directly.... (yay, at last some nixosTest for this monster)
It might make sense to not link anki-sync-server's version with anki's? but then we'd need two separate Cargo.lock files and maintaining the hashes manually for both, that's a bit inefficient; it's probably best to keep in sync as much as possible and just update to 23.10 when it gets released.
Cc @telotortium
Things done
./result/bin/)