Update fceux from v2.6.4 to v2.6.6.#282415
Closed
fmahnke wants to merge 1 commit into
Closed
Conversation
AndersonTorres
suggested changes
Jan 20, 2024
Member
AndersonTorres
left a comment
AndersonTorres
left a comment
There was a problem hiding this comment.
Reword the commit message according to the contribution guidelines.
Member
There was a problem hiding this comment.
Suggested change
| version = "v2.6.6"; | |
| version = "2.6.6"; |
Version should start with a digit
Member
There was a problem hiding this comment.
Suggested change
| rev = "${finalAttrs.version}"; | |
| rev = "v${finalAttrs.version}"; |
Member
|
I am interested in keeping this! |
Fixes build error on GCC 13.
13 tasks
Contributor
Author
|
I made the suggested changes. Thanks for your help. I'm new to contributing to nixpkgs. |
ofborg
Bot
added
10.rebuild-darwin: 0
Member
|
Well, I did something at #282424 I decided to step-up the updates. Instead of jumping from 2.6.4 to 2.6.6 I "fixed" the underlying 2.6.5. The scubed2 fork was updated 4 years ago. I believe I should fill for abandonment. The latest from sbruder was harder to find: I will wait for them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current v2.6.4 fails to build on master because of the GCC 13 change. That version is from 2022, so it seems like it would be a good thing to upgrade unstable anyway.
Description of changes
Upgrades
fceuxfrom its current version 2.6.4 to the latest release version 2.6.6.CC maintainers @sbruder @scubed2
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.