Skip to content

fceux: update and adopt#282424

Merged
SuperSandro2000 merged 5 commits into
NixOS:masterfrom
atorres1985-contrib:fceux
Jan 30, 2024
Merged

fceux: update and adopt#282424
SuperSandro2000 merged 5 commits into
NixOS:masterfrom
atorres1985-contrib:fceux

Conversation

@AndersonTorres
Copy link
Copy Markdown
Member

@AndersonTorres AndersonTorres commented Jan 20, 2024

Description of changes

Closes #282415

Many thanks to @fmahnke

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@AndersonTorres AndersonTorres marked this pull request as ready for review January 20, 2024 21:57
@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Jan 21, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3308

@SuperSandro2000
Copy link
Copy Markdown
Member

SuperSandro2000 commented Jan 21, 2024

Is there any other motivation for the unstable update other than that the last release is from August 2023?

@ofborg ofborg Bot requested review from sbruder and scubed2 January 21, 2024 00:54
@ofborg ofborg Bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 21, 2024
@AndersonTorres AndersonTorres mentioned this pull request Jan 21, 2024
Closed
13 tasks
@AndersonTorres
Copy link
Copy Markdown
Member Author

AndersonTorres commented Jan 21, 2024

Is there any other motivation for the unstable update other than that the last release is from August 2023?

Yes and no.
My main motivation was/is to catch HEAD, indeed.

On the other hand I found at least one serious update: a memleak caused by not closing file handlers
TASEmulators/fceux@d86c81e

There is also updates for QT6 - but I don't know how to make this choice between QTs a smooth and elegant experience.

@trofi
Copy link
Copy Markdown
Contributor

trofi commented Jan 28, 2024

Result of nixpkgs-review pr 282424 run on x86_64-linux 1

1 package built:
  • fceux

@trofi
Copy link
Copy Markdown
Contributor

trofi commented Jan 28, 2024

Also fixes build failure happening on master due to gcc-13 update: https://hydra.nixos.org/build/247726311

SuperSandro2000
SuperSandro2000 approved these changes Jan 29, 2024
View reviewed changes
Comment thread pkgs/applications/emulators/fceux/default.nix Outdated
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 29, 2024
AndersonTorres and others added 5 commits January 30, 2024 07:21
@AndersonTorres
fceux: update meta
5edaccb 
- get rid of nested with
- add AndersonTorres to maintainers
- remove scubed2
- add changelog
@AndersonTorres
fceux: 2.6.4 -> 2.6.5
2fd4f1f 
Also, pin stdenv to GCC12 - yet another case of updated incompatible C++
standards I suppose.

Oh! Remove it when next version arrives ;)
@AndersonTorres @fmahnke
fceux: 2.6.5 -> 2.6.6
0326813 
Co-authored-by: Fritz Mahnke <fritz@mahnke.tech>
@AndersonTorres
fceux: unpin lua and stdenv
6033d9e
@AndersonTorres
fceux: 2.6.6 -> 2.6.6-unstable-2024-01-19
6719d95 
Since 2.6.6 is from August 2023.
@SuperSandro2000 SuperSandro2000 merged commit 664a237 into NixOS:master Jan 30, 2024
@Sigmanificient Sigmanificient added the 0.kind: package adoption Requests or PRs for adopting packages that have no maintainers label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@scubed2 scubed2 Awaiting requested review from scubed2

@sbruder sbruder Awaiting requested review from sbruder

Assignees

No one assigned

Labels

0.kind: package adoption Requests or PRs for adopting packages that have no maintainers 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AndersonTorres @nixos-discourse @SuperSandro2000 @trofi @delroth @Sigmanificient