fix kmscon module by hustlerone · Pull Request #391574 · NixOS/nixpkgs

hustlerone · 2025-03-20T14:18:49Z

Things done

Adjusted the systemd unit for kmscon to fix #385497

This however will completely disable DRM for kmscon and now seats will be unspecified.
If someone absolutely requires DRM for kmscon, let me know.

Add a 👍 reaction to pull requests you find important.

hustlerone · 2025-03-20T14:25:55Z

As per fbcon fashion, there's rendering issues. I guess the PR will get much more complicated if this doesn't turn out to be a fluke.

hustlerone · 2025-03-20T14:32:08Z

Ok, this might just be a greetd issue I'm having.

Either way, it would be great if someone would test this under "normal" circumstances

liff · 2025-03-21T06:00:06Z

Enabled with GNOME and it seems to work like it used to. Didn’t test extensively, but at least GDM is able to start now.

hustlerone · 2025-03-22T11:51:28Z

Yeah, I suspect the current rev we're in actually works as intended and we actually have to disable DRM specifically.

There also is the option to patch kmscon to allow it to free the gpu on demand. However, we would also have to modify every single derivation that starts a graphical session or needs /dev/dri/cardX so it also tells kmscon to free the GPU, just so we use DRM for kmscon (and I don't know any benefits of using DRM over fbcon for kmscon)

hustlerone · 2025-03-30T13:41:46Z

how do i undo this git has played me

nixos-discourse · 2025-04-04T12:44:56Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5352

hustlerone · 2026-01-27T11:09:22Z

That's strange considering i copied the service verbatim.

I don't have the issue on agetty. What's your setup?

gaelj · 2026-01-27T12:07:04Z

I'm using zsh too and it's working well for me when the VT is opened first time, which covers 90% of my use. But if I open another VT and then I go back into an already open VT:

screen stays black until I press a key (always)
Ctrl key appears to be "stuck" (always pressed) but this happens on random. I haven't found a way to unstick it once the VT is in this mode

However both problems still exist when I don't use this PR, so it looks like an upstream issue.

r-vdp · 2026-02-08T22:01:34Z

        '';
      };

+      kmscon = mkOption {


Suggested change

kmscon = mkOption {

kmsconGettyArgs = mkOption {

r-vdp · 2026-02-08T22:01:50Z

  cfg = config.services.kmscon;
-
-  autologinArg = lib.optionalString (cfg.autologinUser != null) "-f ${cfg.autologinUser}";
+  gettyCmd = config.services.getty.kmscon;


Suggested change

gettyCmd = config.services.getty.kmscon;

gettyCmd = config.services.getty.kmsconGettyArgs;

r-vdp · 2026-02-08T22:02:52Z

      package = mkPackageOption pkgs "kmscon" { };

-      hwRender = mkEnableOption "3D hardware acceleration to render the console";
+      hwRender = mkEnableOption "Enable hardware acceleration + DRM backend";


Suggested change

hwRender = mkEnableOption "Enable hardware acceleration + DRM backend";

hwRender = mkEnableOption "hardware acceleration + DRM backend";

mkEnableOption adds "Enable" or something like that to the description already.

r-vdp · 2026-02-08T22:05:34Z

+      cfg.package
+    ];

    systemd.services."kmsconvt@" = {


Why are you repeating here a bunch of settings that will already be loaded by the service included in the package? I think you should only set the options that are not already in the upstream service.

We'd have to patch kmscon for that.

After all, some consistency regarding agetty would be nice.

Why is that? You can just load the service from the package and then set additional settings in the nixos module, or unset and reset. We do that in so many places.

@r-vdp You can take a look at my attempt in #489469.

You can just load the service from the package

~~For some reason, it doesn't work.~~ It's ready now.

OK, why did you open a new PR? This one can be closed then?

I'm traveling today, so I'll probably only be able to try out the other PR tomorrow.

Why is that? You can just load the service from the package and then set additional settings in the nixos module, or unset and reset. We do that in so many places.

Because you'd have to edit kmscon@vt.service.in, or edit it a posteriori.

There's no need to manually modify the systemd unit files. Changes made in the config will be saved as an overlay.
My PR utilizes the unit files provided by kmscon. It has now passed testing and is ready.

Yes indeed, that's what I meant, I didn't notice that the new PR is by a different author.

I'll have a look at it tomorrow.

@hustlerone are you OK with this? Attribution was maintained in the new PR for your commit that was cherry-picked from here.

yes go ahead

ccicnce113424 · 2026-02-09T18:31:04Z

`nixpkgs-review` result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 391574 -p nixosTests.kmscon
Commit: 0b68ffcf72d7f2563ae40557d37e69d67a783108 (subsequent changes)
Merge: f1ff1e74adee25bc83ca41500f99d2825b10f8af

Logs: https://github.com/ccicnce113424/nixpkgs-review-gha/actions/runs/21835473974

`x86_64-linux`

✅ 1 test built:

nixosTests.kmscon

Cherry-picked from NixOS#391574 Co-authored-by: ccicnce113424 <ccicnce113424@gmail.com>

ccicnce113424 · 2026-03-18T15:49:46Z

Closed as #489469 has been merged.

github-actions Bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 20, 2025

hustlerone mentioned this pull request Mar 20, 2025

nixos/kmscon: prevents entering the desktop environment #385497

Closed

3 tasks

hustlerone marked this pull request as draft March 20, 2025 14:25

github-actions Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 20, 2025

hustlerone marked this pull request as ready for review March 20, 2025 14:31

hustlerone requested review from nicoonoclaste and omasanori March 22, 2025 11:52

hustlerone mentioned this pull request Mar 22, 2025

Update Request: pkg/buffybox -> 56a9867e90ece88596e330774da64cf277069b59 #392081

Closed

3 tasks

hustlerone requested a review from RossComputerGuy March 23, 2025 19:51

hustlerone force-pushed the master branch from f96fe99 to ec19bc3 Compare March 30, 2025 13:40

github-actions Bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 30, 2025

hustlerone force-pushed the master branch from ec19bc3 to fd25d54 Compare March 30, 2025 13:47

hustlerone force-pushed the master branch from fd25d54 to 3455095 Compare April 4, 2025 12:49

SuperSandro2000 reviewed Apr 4, 2025

View reviewed changes

Comment thread nixos/modules/services/ttys/kmscon.nix Outdated

SuperSandro2000 reviewed Apr 4, 2025

View reviewed changes

Comment thread nixos/modules/services/ttys/kmscon.nix Outdated

hustlerone force-pushed the master branch from 725f107 to ffc81ba Compare January 24, 2026 10:41

nixpkgs-ci Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 24, 2026

gaelj suggested changes Jan 24, 2026

View reviewed changes

Comment thread nixos/modules/services/ttys/kmscon.nix

nixos/kmscon: run agetty under kmscon

0b68ffc

hustlerone force-pushed the master branch from ffc81ba to 0b68ffc Compare January 24, 2026 18:52

hustlerone requested a review from gaelj January 24, 2026 18:53

gaelj approved these changes Jan 24, 2026

View reviewed changes

nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 24, 2026

ccicnce113424 approved these changes Jan 27, 2026

View reviewed changes

nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 27, 2026

This comment was marked as duplicate.

Sign in to view

ccicnce113424 requested review from ccicnce113424 and removed request for ccicnce113424 and omasanori January 27, 2026 09:50

This comment was marked as resolved.

Sign in to view

ccicnce113424 approved these changes Jan 27, 2026

View reviewed changes

This comment was marked as outdated.

Sign in to view

r-vdp requested changes Feb 8, 2026

View reviewed changes

ccicnce113424 added a commit to ccicnce113424/nixpkgs that referenced this pull request Feb 11, 2026

nixos/kmscon: run agetty under kmscon

7cf1f69

Cherry-picked from NixOS#391574 Co-authored-by: ccicnce113424 <ccicnce113424@gmail.com>

ccicnce113424 added a commit to ccicnce113424/nixpkgs that referenced this pull request Feb 11, 2026

nixos/kmscon: run agetty under kmscon

d7150cc

Cherry-picked from NixOS#391574 Co-authored-by: ccicnce113424 <ccicnce113424@gmail.com>

ccicnce113424 mentioned this pull request Feb 11, 2026

kmscon: 9.3.1 -> 9.3.2, nixos/kmscon: run agetty under kmscon #489469

Merged

13 tasks

ccicnce113424 added a commit to ccicnce113424/nixpkgs that referenced this pull request Feb 11, 2026

nixos/kmscon: run agetty under kmscon

fae1724

Cherry-picked from NixOS#391574 Co-authored-by: ccicnce113424 <ccicnce113424@gmail.com>

flexiondotorg mentioned this pull request Feb 21, 2026

fix(console): start kmscon proactively on VT1 to avoid blank screen o… wimpysworld/nix-config#659

Merged

	gettyCmd = config.services.getty.kmscon;
	gettyCmd = config.services.getty.kmsconGettyArgs;

	hwRender = mkEnableOption "Enable hardware acceleration + DRM backend";
	hwRender = mkEnableOption "hardware acceleration + DRM backend";

Uh oh!

Conversation

hustlerone commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

hustlerone commented Mar 20, 2025

Uh oh!

hustlerone commented Mar 20, 2025

Uh oh!

liff commented Mar 21, 2025

Uh oh!

hustlerone commented Mar 22, 2025

Uh oh!

hustlerone commented Mar 30, 2025

Uh oh!

nixos-discourse commented Apr 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as resolved.

Uh oh!

hustlerone commented Jan 27, 2026

Uh oh!

This comment was marked as resolved.

gaelj commented Jan 27, 2026

Uh oh!

This comment was marked as resolved.

This comment was marked as outdated.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

r-vdp Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ccicnce113424 Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ccicnce113424 commented Feb 9, 2026

nixpkgs-review result

x86_64-linux

Uh oh!

ccicnce113424 commented Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

hustlerone commented Mar 20, 2025 •

edited

Loading

r-vdp Feb 8, 2026 •

edited

Loading

ccicnce113424 Feb 12, 2026 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`