Skip to content

kmscon: 9.3.1 -> 9.3.2, nixos/kmscon: run agetty under kmscon#489469

Merged
r-vdp merged 3 commits into
NixOS:masterfrom
ccicnce113424:kmscon
Mar 18, 2026
Merged

kmscon: 9.3.1 -> 9.3.2, nixos/kmscon: run agetty under kmscon#489469
r-vdp merged 3 commits into
NixOS:masterfrom
ccicnce113424:kmscon

Conversation

@ccicnce113424
Copy link
Copy Markdown
Member

@ccicnce113424 ccicnce113424 commented Feb 11, 2026 •
edited
Loading

Based on #490911.
Cherry-picked from #391574.
Closes #385497 and #391574.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 11, 2026
@ccicnce113424 ccicnce113424 marked this pull request as draft February 11, 2026 17:17
@nixpkgs-ci nixpkgs-ci Bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Feb 11, 2026
@ccicnce113424 ccicnce113424 force-pushed the kmscon branch 5 times, most recently from 586855e to da84196 Compare February 11, 2026 18:53
@ccicnce113424 ccicnce113424 mentioned this pull request Feb 12, 2026
Closed
13 tasks
@ccicnce113424 ccicnce113424 marked this pull request as ready for review February 12, 2026 06:32
@nixpkgs-ci nixpkgs-ci Bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Feb 12, 2026
@ccicnce113424 ccicnce113424 force-pushed the kmscon branch 4 times, most recently from 396e326 to a3a14a8 Compare February 12, 2026 07:27
@ccicnce113424
Copy link
Copy Markdown
Member Author

ccicnce113424 commented Feb 12, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 489469 -p nixosTests.kmscon
Commit: a3a14a8b5037c83d4deff1d16e1bff472950c677 (subsequent changes)
Merge: 39f6977d61b6dd6a843bfc7ff57de1dd5c5a1e66

Logs: https://github.com/ccicnce113424/nixpkgs-review-gha/actions/runs/21937513555

x86_64-linux

✅ 1 test built:
  • nixosTests.kmscon

@ccicnce113424 ccicnce113424 force-pushed the kmscon branch 3 times, most recently from 3419548 to fdcc488 Compare February 16, 2026 03:46
@ccicnce113424 ccicnce113424 changed the title nixos/kmscon: run agetty under kmscon nixos/kmscon: run agetty under kmscon, kmscon: 9.3.1 -> 9.3.2 Feb 16, 2026
@nixpkgs-ci nixpkgs-ci Bot added the 8.has: package (update) This PR updates a package to a newer version label Feb 16, 2026
@ccicnce113424 ccicnce113424 mentioned this pull request Feb 16, 2026
Closed
@r-vdp
Copy link
Copy Markdown
Contributor

r-vdp commented Mar 13, 2026

Sure, did you make any changes? I haven't had to time to dive into the details myself so far.
I'll give it another go tomorrow morning.

@ccicnce113424
Copy link
Copy Markdown
Member Author

ccicnce113424 commented Mar 13, 2026

I have told login to preserve the environment.

Prince213
Prince213 previously requested changes Mar 14, 2026
View reviewed changes
Comment thread nixos/modules/services/ttys/getty.nix Outdated
Comment thread pkgs/by-name/km/kmscon/package.nix Outdated
Comment thread pkgs/by-name/km/kmscon/package.nix Outdated
@ccicnce113424 ccicnce113424 requested a review from Prince213 March 14, 2026 04:24
@Prince213 Prince213 dismissed their stale review March 14, 2026 06:26

Resolved.

@ccicnce113424 ccicnce113424 force-pushed the kmscon branch 2 times, most recently from 3791d86 to 8bd757f Compare March 14, 2026 18:39
@ccicnce113424
Copy link
Copy Markdown
Member Author

ccicnce113424 commented Mar 15, 2026

@ofborg test kmscon

@ShadowRZ
Copy link
Copy Markdown
Member

ShadowRZ commented Mar 15, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 489469
Commit: 8bd757f3aa88470911ce9dc398faeab53a832ded (subsequent changes)
Merge: 423168922f2eb5f9bc44bd9f77c953b2ee8a409d

Logs: https://github.com/ShadowRZ/nixpkgs-review-gha/actions/runs/23107587421

x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 2 packages built:
  • kmscon
  • kmscon.man

aarch64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 2 packages built:
  • kmscon
  • kmscon.man

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@ccicnce113424
Copy link
Copy Markdown
Member Author

ccicnce113424 commented Mar 15, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 489469 -p nixosTests.kmscon
Commit: 8bd757f3aa88470911ce9dc398faeab53a832ded (subsequent changes)
Merge: 423168922f2eb5f9bc44bd9f77c953b2ee8a409d

Logs: https://github.com/ccicnce113424/nixpkgs-review-gha/actions/runs/23108439590

x86_64-linux

✅ 1 test built:
  • nixosTests.kmscon

@ccicnce113424 ccicnce113424 force-pushed the kmscon branch 2 times, most recently from 95c2039 to 27dc551 Compare March 15, 2026 17:23
Prince213
Prince213 reviewed Mar 18, 2026
View reviewed changes
Comment thread nixos/modules/services/ttys/kmscon.nix Outdated
@ccicnce113424 ccicnce113424 requested a review from Prince213 March 18, 2026 07:58
r-vdp
r-vdp approved these changes Mar 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@r-vdp r-vdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and is working fine now on my system since a couple of days.

One small comment and then I think we're good to send this.

Thanks for your persistence with this PR!

Comment thread nixos/modules/services/ttys/kmscon.nix
@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 18, 2026
@hustlerone @ccicnce113424
nixos/kmscon: run agetty under kmscon
be703cf 
Cherry-picked from NixOS#391574

Co-authored-by: ccicnce113424 <ccicnce113424@gmail.com>
@ccicnce113424 ccicnce113424 requested a review from r-vdp March 18, 2026 15:05
@r-vdp r-vdp added this pull request to the merge queue Mar 18, 2026
Merged via the queue into NixOS:master with commit 7eb6c66 Mar 18, 2026
28 of 31 checks passed
alyssais
alyssais reviewed Mar 23, 2026
View reviewed changes
Comment thread nixos/modules/services/ttys/getty.nix
assertions = [
{
assertion = cfg.loginOptions != null -> cfg.autologinUser == null;
message = "services.getty.autoLoginUser has no effect when services.getty.loginOptions is set.";
Copy link
Copy Markdown
Member

@alyssais alyssais Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assertion has broken my config, and as far as I can tell, it's just not true, is it?

nixpkgs/nixos/modules/services/ttys/getty.nix

Lines 17 to 24 in be703cf

++ optionals (cfg.autologinUser != null && !cfg.autologinOnce) [
"--autologin"
cfg.autologinUser
]
++ optionals (cfg.loginOptions != null) [
"--login-options"
cfg.loginOptions
]

Copy link
Copy Markdown
Member Author

@ccicnce113424 ccicnce113424 Mar 24, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

​This assertion is not entirely accurate. While \u within --login-options is correctly expanded, the --autologin flag fails to append -f automatically when --login-options is defined. Thus, it is not strictly "has no effect," but manually adding -f to the login options remains necessary.

@bokicoder bokicoder mentioned this pull request Mar 24, 2026
Merged
13 tasks
@alyssais alyssais mentioned this pull request Mar 24, 2026
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alyssais alyssais alyssais left review comments

@RossComputerGuy RossComputerGuy Awaiting requested review from RossComputerGuy

@Prince213 Prince213 Awaiting requested review from Prince213

@r-vdp r-vdp Awaiting requested review from r-vdp

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

nixos/kmscon: prevents entering the desktop environment

8 participants

@ccicnce113424 @r-vdp @nixos-discourse @ShadowRZ @alyssais @Prince213 @r-ryantm @hustlerone