noresm2_3_beta02: Add RafWBF parameterization for Bergeron factor by mvdebolskiy · Pull Request #274 · NorESMhub/CAM

mvdebolskiy · 2026-04-26T14:50:57Z

Summary: Adds a random-forest parameterization for determining a factor for Bergeron process.

Reviewers: @gold2718 @DirkOlivie @oyvindseland

Purpose of changes:

Github PR URL:

Changes made to build system: added namelist options

Changes made to the namelist: added rafwbf_on_on and forestfileWBF namelist vars in group wbf_nl. The switch defaults to .false.

Changes to the defaults for the boundary datasets: None

Substantial timing or memory changes: TBD

[ Detailed description of changes ]

[ List each test suite run. For each suite, include machine, compiler, and any test failures.
For each failure, include the contents of TestStatus or the output from cs.status.testid for that test ]

Issues addressed by this PR: None

oyvindseland · 2026-04-27T06:19:17Z

Has it been tested to give bit-identical results with the switch default to false?

mvdebolskiy · 2026-04-27T18:02:59Z

@oyvindseland I am doing that right now.

mvdebolskiy · 2026-04-28T14:44:20Z

@oyvindseland @gold2718 aux_cam_noresm and prealpha_noresm showed only NLCOMP fails. @sldamman will check the output scientifically, so it will be gtg in a couple of days.

gold2718

Please see change requests.

gold2718 · 2026-04-28T14:02:02Z

+
+<entry id="forestfileWBF" type="char*256" input_pathname="abs" category="microphys"
+       group="wbf_nl" valid_values="" >
+  ML parameters for Damman et al., ...


Is there supposed to be a reference here?
This needs some reference / documentation.

It's not published yet.

Then, please include the title and current submission status (e.g., journal, status).

gold2718 · 2026-04-28T19:43:45Z

+     ! RaFWBF parameterisattion:
+     if (rafwbf_on) then
+        do i = 1,mgncol
+           if (t(i,k) .le. 273.15_r8 .and. t(i,k) .ge. 235.15_r8) then


All of these uses of 273.15 (here and below) should use physconst, only: tmelt. Also, please use modern Fortran syntax:

Suggested change

if (t(i,k) .le. 273.15_r8 .and. t(i,k) .ge. 235.15_r8) then

if (t(i,k) <= tmelt .and. t(i,k) >= 235.15_r8) then

Also, it would be great if you could define and document a parameter for 235.15_r8 and use that.

gold2718 · 2026-04-28T19:47:09Z

 !===============================================================================

-subroutine micro_mg_cam_tend(state, ptend, dtime, pbuf)
+subroutine micro_mg_cam_tend(state, ptend, dtime, cam_in, pbuf)


Do not pass in an entire structure for one variable. Pass just ts.

gold2718 · 2026-04-28T19:48:35Z

+          close(unitn)
+        end if
+      else
+         call endrun(subname//':: ERROR rafwbf_on = .true. is incompatible with micro_mg_version=2')


Shouldn't this be version 1?

Suggested change

call endrun(subname//':: ERROR rafwbf_on = .true. is incompatible with micro_mg_version=2')

call endrun(subname//':: ERROR rafwbf_on = .true. is incompatible with micro_mg_version=1')

gold2718 · 2026-04-28T19:49:40Z


          if (use_subcol_microp) then
-             call microp_driver_tend(state_sc, ptend_sc, cld_macmic_ztodt, pbuf)
+             call microp_driver_tend(state_sc, ptend_sc, cld_macmic_ztodt, cam_in, pbuf)


See change request in micro_mg_cam.F90

gold2718 · 2026-04-28T19:53:08Z


   use micro_mg1_0, only: micro_mg_get_cols1_0 => micro_mg_get_cols
   use micro_mg2_0, only: micro_mg_get_cols2_0 => micro_mg_get_cols
+   use camsrfexch,  only: cam_in_t


Only ts should be passed so this will not be necessary.

gold2718 · 2026-04-28T19:53:34Z

   case ('MG')
      call t_startf('microp_mg_tend')
-      call micro_mg_cam_tend(state, ptend, dtime, pbuf)
+      call micro_mg_cam_tend(state, ptend, dtime, cam_in, pbuf)


Only pass ts:

Suggested change

call micro_mg_cam_tend(state, ptend, dtime, cam_in, pbuf)

call micro_mg_cam_tend(state, ptend, dtime, cam_in%ts, pbuf)

gold2718 · 2026-04-29T09:56:06Z

@oyvindseland @gold2718 aux_cam_noresm and prealpha_noresm showed only NLCOMP fails. @sldamman will check the output scientifically, so it will be gtg in a couple of days.

Given how much code is impacted, a short test should be added (can be short SMS test) to protect the baseline moving forwards.

Co-authored-by: goldy <1588651+gold2718@users.noreply.github.com>

mvdebolskiy · 2026-04-29T18:22:53Z

I've rerun aux_cam only nlcomp fails + 1 baseline fail for the new test.

gold2718

This is much better but still needs some fixes.
Also, please do not resolve my comments and change requests. I need to see them to make sure everything is resolved.

gold2718 · 2026-04-30T14:15:53Z

+              Tb    = t(i,k) - 273.15_r8    ! DegC
+              PBLHb = pblh(i)               !m
+              TSKb  = tsk(i) - 273.15       ! DegC


Are these constants explicitly supposed to be the same as tupb? tmelt? Given the comment, it seems that these should be replaced with tmelt.

gold2718 · 2026-04-30T14:16:46Z

+     ! RaFWBF parameterisattion:
+     if (rafwbf_on) then
+        do i = 1,mgncol
+           if (t(i,k) >= tupb .and. t(i,k) <= tlob) then


Have you tested this change? I do not see how it is ever .true..

mvdebolskiy added 2 commits April 26, 2026 16:38

add nl vars

1e128d9

add var processing

0a769c0

mvdebolskiy marked this pull request as draft April 26, 2026 14:51

mvdebolskiy added 3 commits April 26, 2026 20:11

pipe inputs and add calcs

ab01817

make normal cam accept same args

149f4ea

bound rf output fix typo

849508d

mvdebolskiy added 2 commits April 27, 2026 19:40

fix compile errors and namelists

5c5a2f0

add testmod

dd93f6c

mvdebolskiy mentioned this pull request Apr 28, 2026

PR-noresm2.3.0 NorESMhub/NorESM#788

Open

24 tasks

mvdebolskiy marked this pull request as ready for review April 28, 2026 14:42

gold2718 requested changes Apr 28, 2026

View reviewed changes

mvdebolskiy and others added 3 commits April 29, 2026 16:48

add tests and address comments.

a04007b

fix mg version exception

67a2068

Co-authored-by: goldy <1588651+gold2718@users.noreply.github.com>

fix missed arg

a82ecc1

mvdebolskiy requested a review from gold2718 April 29, 2026 18:22

swtich input to grid content and not just cloud

18d4edf

gold2718 requested changes Apr 30, 2026

View reviewed changes

fix tyypi in condition

b4a8ee4

	if (t(i,k) .le. 273.15_r8 .and. t(i,k) .ge. 235.15_r8) then
	if (t(i,k) <= tmelt .and. t(i,k) >= 235.15_r8) then

	call endrun(subname//':: ERROR rafwbf_on = .true. is incompatible with micro_mg_version=2')
	call endrun(subname//':: ERROR rafwbf_on = .true. is incompatible with micro_mg_version=1')

	call micro_mg_cam_tend(state, ptend, dtime, cam_in, pbuf)
	call micro_mg_cam_tend(state, ptend, dtime, cam_in%ts, pbuf)

Conversation

mvdebolskiy commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oyvindseland commented Apr 27, 2026

Uh oh!

mvdebolskiy commented Apr 27, 2026

Uh oh!

mvdebolskiy commented Apr 28, 2026

Uh oh!

gold2718 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gold2718 commented Apr 29, 2026

Uh oh!

mvdebolskiy commented Apr 29, 2026

Uh oh!

gold2718 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mvdebolskiy commented Apr 26, 2026 •

edited

Loading