forked from ESCOMP/CAM
-
Notifications
You must be signed in to change notification settings - Fork 26
noresm2_3_beta02: Add RafWBF parameterization for Bergeron factor #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mvdebolskiy
wants to merge
12
commits into
NorESMhub:noresm2_3_develop
Choose a base branch
from
mvdebolskiy:add-raf-berg
base: noresm2_3_develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1e128d9
add nl vars
mvdebolskiy 0a769c0
add var processing
mvdebolskiy ab01817
pipe inputs and add calcs
mvdebolskiy 149f4ea
make normal cam accept same args
mvdebolskiy 849508d
bound rf output fix typo
mvdebolskiy 5c5a2f0
fix compile errors and namelists
mvdebolskiy dd93f6c
add testmod
mvdebolskiy a04007b
add tests and address comments.
mvdebolskiy 67a2068
fix mg version exception
mvdebolskiy a82ecc1
fix missed arg
mvdebolskiy 18d4edf
swtich input to grid content and not just cloud
mvdebolskiy b4a8ee4
fix tyypi in condition
mvdebolskiy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| ./xmlchange ROF_NCPL=\$ATM_NCPL | ||
| ./xmlchange GLC_NCPL=\$ATM_NCPL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| mfilt = 1,1,1,1,1,1 | ||
| ndens = 1,1,1,1,1,1 | ||
| nhtfrq = 9,9,9,9,9,9 | ||
| inithist = 'ENDOFRUN' | ||
| history_budget = .true. | ||
| rafwbf_on = .true. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| !---------------------------------------------------------------------------------- | ||
| ! Users should add all user specific namelist changes below in the form of | ||
| ! namelist_var = new_namelist_value | ||
| ! | ||
| ! Include namelist variables for drv_flds_in ONLY if -megan and/or -drydep options | ||
| ! are set in the CLM_NAMELIST_OPTS env variable. | ||
| ! | ||
| ! EXCEPTIONS: | ||
| ! Set use_cndv by the compset you use and the CLM_BLDNML_OPTS -dynamic_vegetation setting | ||
| ! Set use_vichydro by the compset you use and the CLM_BLDNML_OPTS -vichydro setting | ||
| ! Set use_cn by the compset you use and CLM_BLDNML_OPTS -bgc setting | ||
| ! Set use_crop by the compset you use and CLM_BLDNML_OPTS -crop setting | ||
| ! Set spinup_state by the CLM_BLDNML_OPTS -bgc_spinup setting | ||
| ! Set irrigate by the CLM_BLDNML_OPTS -irrig setting | ||
| ! Set dtime with L_NCPL option | ||
| ! Set fatmlndfrc with LND_DOMAIN_PATH/LND_DOMAIN_FILE options | ||
| ! Set finidat with RUN_REFCASE/RUN_REFDATE/RUN_REFTOD options for hybrid or branch cases | ||
| ! (includes $inst_string for multi-ensemble cases) | ||
| ! Set glc_grid with CISM_GRID option | ||
| ! Set glc_smb with GLC_SMB option | ||
| ! Set maxpatch_glcmec with GLC_NEC option | ||
| ! Set glc_do_dynglacier with GLC_TWO_WAY_COUPLING env variable | ||
| !---------------------------------------------------------------------------------- | ||
| hist_nhtfrq = 9 | ||
| hist_mfilt = 1 | ||
| hist_ndens = 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these constants explicitly supposed to be the same as
tupb?tmelt? Given the comment, it seems that these should be replaced withtmelt.