Update for h5ad reader#147
Merged
parashardhapola merged 6 commits intoNov 19, 2025
Merged
Conversation
| @@ -782,6 +782,25 @@ def feat_names(self) -> np.ndarray: | |||
| return self.feat_ids() | |||
|
|
|||
| def _replace_category_values(self, v: np.ndarray, key: str, group: str): | |||
Member
There was a problem hiding this comment.
we need to update this signature, as now we expect v to not just be np.ndarray
Contributor
Author
There was a problem hiding this comment.
noted. fix made in new commits
| values = self.h5[self.featureAttrsKey][self.featNamesKey] | ||
| else: | ||
| values = self.h5[self.featureAttrsKey][self.featNamesKey][:] | ||
| values = self.h5[self.featureAttrsKey][self.featNamesKey] |
Member
There was a problem hiding this comment.
this is change because now you are feeddng values into _replace_category_values?
Contributor
Author
There was a problem hiding this comment.
looking at the return, i think values was always passed.
i've cleaned out the if else now
parashardhapola
approved these changes
Nov 19, 2025
parashardhapola
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: Categorical feature names in H5AD files caused TypeError
Fix:
Result: H5AD files with categorical data now load