[19.0][MIG] connector: Migration to 19.0#511
Conversation
Does not do particular checks to see if each "step" is a valid m2o field, relies on the standard and familiar Odoo recordset errors instead.
The job function, channel and worker fields are too large for a 6 column layout. Job function and channel make the fields overflow of the form and the worker fields is wrapped over 3 lines
…cified (to avoid timedelta error when seconds is None) in job.py.
Plus various cosmetic improvements.
The job will be retried after the given number of seconds if the exception is raised with a defined 'seconds' argument.
Currently translated at 100.0% (10 of 10 strings) Translation: connector-17.0/connector-17.0-connector Translate-URL: https://translation.odoo-community.org/projects/connector-17-0/connector-17-0-connector/it/
Currently translated at 100.0% (10 of 10 strings) Translation: connector-17.0/connector-17.0-connector Translate-URL: https://translation.odoo-community.org/projects/connector-17-0/connector-17-0-connector/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: connector-18.0/connector-18.0-connector Translate-URL: https://translation.odoo-community.org/projects/connector-18-0/connector-18-0-connector/
|
Hello @mkoeck , thank you for your contribution. Could you please attend the CI errors? 🙏 |
|
Hi @vvrossem if I remember correctly the tests are only failing because the dependant modules are not yet updated. I pulled in the open PRs for those locally and I think tests passed. I since learned that it is possible to add a temporary dependency (or whatever its called), but I am not too familiar with it. If I have the time I will look into it, but these problems should resolve once the PRs for the other modules are merged. |
|
Hello @mkoeck , Could you check the failing tests and fix the |
9af9cfa to
1dbed57
Compare
5c5099f to
dd03d67
Compare
|
@imlopes I think this looks right now |
|
@mkoeck thank you for this work. |
| def setUp(self): | ||
| super().setUp() | ||
| self._setup_registry(self) | ||
| self.comp_registry.load_components("component_event") |
There was a problem hiding this comment.
why do we need this change? The TransactionComponentRegistryCase is needed only when you want to register custom components on the fly. When you load components from a module, TransactionComponentCase is enough
| @@ -0,0 +1,3 @@ | |||
| odoo-addon-component @ git+https://github.com/OCA/connector.git@refs/pull/521/head#subdirectory=component | |||
There was a problem hiding this comment.
component and component_event are done
| @@ -0,0 +1,3 @@ | |||
| odoo-addon-component @ git+https://github.com/OCA/connector.git@refs/pull/521/head#subdirectory=component | |||
| odoo-addon-component_event @ git+https://github.com/OCA/connector.git@refs/pull/509/head#subdirectory=component_event | |||
| odoo-addon-queue_job==19.0.* | |||
There was a problem hiding this comment.
queue job is available, this is not needed
|
Hello @mkoeck if you don't mind, I've opened a new PR (to speed up migration process and address the suggestions) (your commits are preserved): @OCA/connector-maintainers can you pls close this one? |
|
@yankinmax yes of course, thank you for taking over. Sorry for not being responsive, I am currently quite busy with work related issues, so I did not find the time to continue here |
Main changes
New security model support
res.groups.privilegerecord introduced in 19.0 and adapted the existing res.groups record accordinglyTest suite updates for 19.0 API
self.env2.reset()calls withself.env2.transaction.reset()in tests.env.context:self.env.context.self.env()to create a new environment insteadexternal_ids are no longer guaranteed to exist.Functional impact
Dependencies
This PR has been tested against the following non-merged branches of dependent modules: