[19.0][MIG] account_invoice_margin_sale: Migration to 19.0 #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (1 of 1 strings) Translation: margin-analysis-13.0/margin-analysis-13.0-account_invoice_margin_sale Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-13-0/margin-analysis-13-0-account_invoice_margin_sale/es/
[UPD] Update account_invoice_margin_sale.pot [UPD] README.rst account_invoice_margin_sale 13.0.1.0.1 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: margin-analysis-13.0/margin-analysis-13.0-account_invoice_margin_sale Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-13-0/margin-analysis-13-0-account_invoice_margin_sale/
[UPD] Update account_invoice_margin_sale.pot [UPD] README.rst
Currently translated at 100.0% (3 of 3 strings) Translation: margin-analysis-14.0/margin-analysis-14.0-account_invoice_margin_sale Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-14-0/margin-analysis-14-0-account_invoice_margin_sale/es/
Currently translated at 100.0% (3 of 3 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-account_invoice_margin_sale Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-account_invoice_margin_sale/fr_FR/
Currently translated at 100.0% (3 of 3 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-account_invoice_margin_sale Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-account_invoice_margin_sale/es/
- Include context keys for avoiding mail operations overhead.
…rder When sale_margin_security is also installed. Closes OCA#194
Currently translated at 100.0% (3 of 3 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-account_invoice_margin_sale Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-account_invoice_margin_sale/it/
dreispt
approved these changes
Feb 1, 2026
Member
dreispt
left a comment
dreispt
left a comment
There was a problem hiding this comment.
LGTM but please:
- remove the pylint disable line
- squash the pre-commit fixes commit
| class AccountMoveLine(models.Model): | ||
| _inherit = "account.move.line" | ||
|
|
||
| # pylint: disable=W8110 |
Member
There was a problem hiding this comment.
Please remove the pylint disable
dreispt
reviewed
Feb 1, 2026
| class AccountMoveLine(models.Model): | ||
| _inherit = "account.move.line" | ||
|
|
||
| # pylint: disable=W8110 |
dreispt
approved these changes
Feb 1, 2026
Member
dreispt
left a comment
dreispt
left a comment
There was a problem hiding this comment.
LGTM but:
- remove the pylint disable line
- squash separate commit with pre-commit fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.