-
-
Notifications
You must be signed in to change notification settings - Fork 179
[19.0][MIG] account_invoice_margin_sale: Migration to 19.0 #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Debora7
wants to merge
24
commits into
OCA:19.0
Choose a base branch
from
dakai-soft:19.0-mig-account-invoice-margin-sale
base: 19.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
5865087
[UPD] Update account_invoice_margin_sale.pot
oca-travis fde1611
Added translation using Weblate (Spanish)
HaraldPanten 873aca6
Translated using Weblate (Spanish)
HaraldPanten 52c98be
[IMP] skip margin calculation for Down Payment invoice
7683e4a
[14.0][MIG] account_invoice_margin_sale: Migration to 14.0
Reyes4711-S73 da14bb2
Translated using Weblate (Spanish)
rafamarpe fc18e35
[MIG] account_invoice_margin_sale: Migration to 15.0
victoralmau d49ed1e
[MIG] account_invoice_margin_sale: Migration to 16.0
ljsalvatierra-factorlibre 78e85c9
[MIG] account_invoice_margin_sale: Migration to 16.0
ljsalvatierra-factorlibre 57cccd2
[UPD] Update account_invoice_margin_sale.pot
ba2ee27
Added translation using Weblate (French (France) (fr_FR))
sanrav 558c4bd
Translated using Weblate (French (France) (fr_FR))
sanrav 70c7fb7
Translated using Weblate (Spanish)
Gelo-fl 35c2914
[IMP] account_invoice_margin_sale: test performance improvement
josep-tecnativa 6777ee6
[FIX] account_invoice_margin_sale: error creating invoice from sale o…
dreispt 7efc12c
Added translation using Weblate (Italian)
mymage cbea55a
Translated using Weblate (Italian)
mymage 1f38e64
[IMP] account_invoice_margin_sale: pre-commit auto fixes
7fa4528
[MIG] account_invoice_margin_sale: Migration to 17.0
73ff048
[MIG] account_invoice_margin_sale: Migration to 18.0
BhaveshHeliconia 0592f4f
[UPD] Update account_invoice_margin_sale.pot
946541a
[BOT] post-merge updates
OCA-git-bot 25bfe90
[MIG] account_invoice_margin_sale: Migration to 19.0
Debora7 c230d6b
Pre-commit fixes.
Debora7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| .. image:: https://odoo-community.org/readme-banner-image | ||
| :target: https://odoo-community.org/get-involved?utm_source=readme | ||
| :alt: Odoo Community Association | ||
|
|
||
| =========================== | ||
| Account Invoice Margin Sale | ||
| =========================== | ||
|
|
||
| .. | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| !! This file is generated by oca-gen-addon-readme !! | ||
| !! changes will be overwritten. !! | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| !! source digest: sha256:2ef725e050cddba9db98fadb21e993ad44d2d5c8743a1672215d5f2e9a6a3440 | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
|
|
||
| .. |badge1| image:: https://img.shields.io/badge/maturity-Production%2FStable-green.png | ||
| :target: https://odoo-community.org/page/development-status | ||
| :alt: Production/Stable | ||
| .. |badge2| image:: https://img.shields.io/badge/license-AGPL--3-blue.png | ||
| :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html | ||
| :alt: License: AGPL-3 | ||
| .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fmargin--analysis-lightgray.png?logo=github | ||
| :target: https://github.com/OCA/margin-analysis/tree/19.0/account_invoice_margin_sale | ||
| :alt: OCA/margin-analysis | ||
| .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png | ||
| :target: https://translation.odoo-community.org/projects/margin-analysis-19-0/margin-analysis-19-0-account_invoice_margin_sale | ||
| :alt: Translate me on Weblate | ||
| .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png | ||
| :target: https://runboat.odoo-community.org/builds?repo=OCA/margin-analysis&target_branch=19.0 | ||
| :alt: Try me on Runboat | ||
|
|
||
| |badge1| |badge2| |badge3| |badge4| |badge5| | ||
|
|
||
| This module propagates purchase price from sale order line to invoice | ||
| and discards the invoice lines coming from sale order lines with | ||
| down-payment when computing the margin. | ||
|
|
||
| **Table of contents** | ||
|
|
||
| .. contents:: | ||
| :local: | ||
|
|
||
| Installation | ||
| ============ | ||
|
|
||
| This module is autoinstalable. | ||
|
|
||
| Usage | ||
| ===== | ||
|
|
||
| This module also needs a security group to show margins. | ||
|
|
||
| 1. To activate it go to user and active "Show Invoice Margin" in | ||
| security options. | ||
|
|
||
| Bug Tracker | ||
| =========== | ||
|
|
||
| Bugs are tracked on `GitHub Issues <https://github.com/OCA/margin-analysis/issues>`_. | ||
| In case of trouble, please check there if your issue has already been reported. | ||
| If you spotted it first, help us to smash it by providing a detailed and welcomed | ||
| `feedback <https://github.com/OCA/margin-analysis/issues/new?body=module:%20account_invoice_margin_sale%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. | ||
|
|
||
| Do not contact contributors directly about support or help with technical issues. | ||
|
|
||
| Credits | ||
| ======= | ||
|
|
||
| Authors | ||
| ------- | ||
|
|
||
| * Tecnativa | ||
|
|
||
| Contributors | ||
| ------------ | ||
|
|
||
| - `Tecnativa <https://www.tecnativa.com>`__: | ||
|
|
||
| - Sergio Teruel | ||
| - Carlos Dauden | ||
| - Víctor Martínez | ||
|
|
||
| - `Open Source Integrators <https://www.opensourceintegrators.com>`__: | ||
|
|
||
| - Bhavesh Odedra | ||
| - Daniel Reis <dreis@opensourceintegrators.com> | ||
|
|
||
| - `Factor Libre <https://www.factorlibre.com>`__: | ||
|
|
||
| - Luis J. Salvatierra | ||
|
|
||
| - `Avoin.Systems <https://avoin.systems/>`__: | ||
|
|
||
| - Nedas Żilinskas | ||
|
|
||
| Maintainers | ||
| ----------- | ||
|
|
||
| This module is maintained by the OCA. | ||
|
|
||
| .. image:: https://odoo-community.org/logo.png | ||
| :alt: Odoo Community Association | ||
| :target: https://odoo-community.org | ||
|
|
||
| OCA, or the Odoo Community Association, is a nonprofit organization whose | ||
| mission is to support the collaborative development of Odoo features and | ||
| promote its widespread use. | ||
|
|
||
| .. |maintainer-sergio-teruel| image:: https://github.com/sergio-teruel.png?size=40px | ||
| :target: https://github.com/sergio-teruel | ||
| :alt: sergio-teruel | ||
| .. |maintainer-carlosdauden| image:: https://github.com/carlosdauden.png?size=40px | ||
| :target: https://github.com/carlosdauden | ||
| :alt: carlosdauden | ||
|
|
||
| Current `maintainers <https://odoo-community.org/page/maintainer-role>`__: | ||
|
|
||
| |maintainer-sergio-teruel| |maintainer-carlosdauden| | ||
|
|
||
| This module is part of the `OCA/margin-analysis <https://github.com/OCA/margin-analysis/tree/19.0/account_invoice_margin_sale>`_ project on GitHub. | ||
|
|
||
| You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
|
||
| from . import models |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # Copyright 2017-2018 Tecnativa - Sergio Teruel | ||
| # Copyright 2019 Tecnativa - Carlos Dauden | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/lgpl). | ||
|
|
||
| { | ||
| "name": "Account Invoice Margin Sale", | ||
| "summary": "Set margin in invoices from sale orders", | ||
| "version": "19.0.1.0.0", | ||
| "development_status": "Production/Stable", | ||
| "maintainers": ["sergio-teruel", "carlosdauden"], | ||
| "category": "Account", | ||
| "website": "https://github.com/OCA/margin-analysis", | ||
| "author": "Tecnativa, Odoo Community Association (OCA)", | ||
| "license": "AGPL-3", | ||
| "application": False, | ||
| "installable": True, | ||
| "auto_install": True, | ||
| "depends": ["sale_margin", "account_invoice_margin"], | ||
| } |
29 changes: 29 additions & 0 deletions
29
account_invoice_margin_sale/i18n/account_invoice_margin_sale.pot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # Translation of Odoo Server. | ||
| # This file contains the translation of the following modules: | ||
| # * account_invoice_margin_sale | ||
| # | ||
| msgid "" | ||
| msgstr "" | ||
| "Project-Id-Version: Odoo Server 18.0\n" | ||
| "Report-Msgid-Bugs-To: \n" | ||
| "Last-Translator: \n" | ||
| "Language-Team: \n" | ||
| "MIME-Version: 1.0\n" | ||
| "Content-Type: text/plain; charset=UTF-8\n" | ||
| "Content-Transfer-Encoding: \n" | ||
| "Plural-Forms: \n" | ||
|
|
||
| #. module: account_invoice_margin_sale | ||
| #: model:ir.model,name:account_invoice_margin_sale.model_account_move | ||
| msgid "Journal Entry" | ||
| msgstr "" | ||
|
|
||
| #. module: account_invoice_margin_sale | ||
| #: model:ir.model,name:account_invoice_margin_sale.model_account_move_line | ||
| msgid "Journal Item" | ||
| msgstr "" | ||
|
|
||
| #. module: account_invoice_margin_sale | ||
| #: model:ir.model,name:account_invoice_margin_sale.model_sale_order_line | ||
| msgid "Sales Order Line" | ||
| msgstr "" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # Translation of Odoo Server. | ||
| # This file contains the translation of the following modules: | ||
| # * account_invoice_margin_sale | ||
| # | ||
| msgid "" | ||
| msgstr "" | ||
| "Project-Id-Version: Odoo Server 13.0\n" | ||
| "Report-Msgid-Bugs-To: \n" | ||
| "PO-Revision-Date: 2023-06-07 19:09+0000\n" | ||
| "Last-Translator: gelo joga Rodríguez <gelo.joga@factorlibre.com>\n" | ||
| "Language-Team: none\n" | ||
| "Language: es\n" | ||
| "MIME-Version: 1.0\n" | ||
| "Content-Type: text/plain; charset=UTF-8\n" | ||
| "Content-Transfer-Encoding: \n" | ||
| "Plural-Forms: nplurals=2; plural=n != 1;\n" | ||
| "X-Generator: Weblate 4.17\n" | ||
|
|
||
| #. module: account_invoice_margin_sale | ||
| #: model:ir.model,name:account_invoice_margin_sale.model_account_move | ||
| msgid "Journal Entry" | ||
| msgstr "Asiento contable" | ||
|
|
||
| #. module: account_invoice_margin_sale | ||
| #: model:ir.model,name:account_invoice_margin_sale.model_account_move_line | ||
| msgid "Journal Item" | ||
| msgstr "Apunte contable" | ||
|
|
||
| #. module: account_invoice_margin_sale | ||
| #: model:ir.model,name:account_invoice_margin_sale.model_sale_order_line | ||
| msgid "Sales Order Line" | ||
| msgstr "Línea de pedido de venta" | ||
|
|
||
| #~ msgid "Journal Entries" | ||
| #~ msgstr "Entradas de diario" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # Translation of Odoo Server. | ||
| # This file contains the translation of the following modules: | ||
| # * account_invoice_margin_sale | ||
| # | ||
| msgid "" | ||
| msgstr "" | ||
| "Project-Id-Version: Odoo Server 16.0\n" | ||
| "Report-Msgid-Bugs-To: \n" | ||
| "PO-Revision-Date: 2023-06-05 18:09+0000\n" | ||
| "Last-Translator: \"Sandrine (ACSONE)\" <sandrine.ravet@acsone.eu>\n" | ||
| "Language-Team: none\n" | ||
| "Language: fr_FR\n" | ||
| "MIME-Version: 1.0\n" | ||
| "Content-Type: text/plain; charset=UTF-8\n" | ||
| "Content-Transfer-Encoding: \n" | ||
| "Plural-Forms: nplurals=2; plural=n > 1;\n" | ||
| "X-Generator: Weblate 4.17\n" | ||
|
|
||
| #. module: account_invoice_margin_sale | ||
| #: model:ir.model,name:account_invoice_margin_sale.model_account_move | ||
| msgid "Journal Entry" | ||
| msgstr "Pièce comptable" | ||
|
|
||
| #. module: account_invoice_margin_sale | ||
| #: model:ir.model,name:account_invoice_margin_sale.model_account_move_line | ||
| msgid "Journal Item" | ||
| msgstr "Ecriture comptable" | ||
|
|
||
| #. module: account_invoice_margin_sale | ||
| #: model:ir.model,name:account_invoice_margin_sale.model_sale_order_line | ||
| msgid "Sales Order Line" | ||
| msgstr "Ligne de commande client" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # Translation of Odoo Server. | ||
| # This file contains the translation of the following modules: | ||
| # * account_invoice_margin_sale | ||
| # | ||
| msgid "" | ||
| msgstr "" | ||
| "Project-Id-Version: Odoo Server 16.0\n" | ||
| "Report-Msgid-Bugs-To: \n" | ||
| "PO-Revision-Date: 2024-01-29 17:38+0000\n" | ||
| "Last-Translator: mymage <stefano.consolaro@mymage.it>\n" | ||
| "Language-Team: none\n" | ||
| "Language: it\n" | ||
| "MIME-Version: 1.0\n" | ||
| "Content-Type: text/plain; charset=UTF-8\n" | ||
| "Content-Transfer-Encoding: \n" | ||
| "Plural-Forms: nplurals=2; plural=n != 1;\n" | ||
| "X-Generator: Weblate 4.17\n" | ||
|
|
||
| #. module: account_invoice_margin_sale | ||
| #: model:ir.model,name:account_invoice_margin_sale.model_account_move | ||
| msgid "Journal Entry" | ||
| msgstr "Registrazione contabile" | ||
|
|
||
| #. module: account_invoice_margin_sale | ||
| #: model:ir.model,name:account_invoice_margin_sale.model_account_move_line | ||
| msgid "Journal Item" | ||
| msgstr "Movimento contabile" | ||
|
|
||
| #. module: account_invoice_margin_sale | ||
| #: model:ir.model,name:account_invoice_margin_sale.model_sale_order_line | ||
| msgid "Sales Order Line" | ||
| msgstr "Riga ordine di vendita" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
|
||
| from . import sale | ||
| from . import account_invoice |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # Copyright 2021 Sergio Teruel <sergio.teruel@tecnativa.com> | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
|
||
| from odoo import api, models | ||
|
|
||
|
|
||
| class AccountMove(models.Model): | ||
| _inherit = "account.move" | ||
|
|
||
| def _get_margin_applicable_lines(self): | ||
| invoice_lines = super()._get_margin_applicable_lines() | ||
| return invoice_lines.filtered( | ||
| lambda x: not any(x.sale_line_ids.mapped("is_downpayment")) | ||
| ) | ||
|
|
||
|
|
||
| class AccountMoveLine(models.Model): | ||
| _inherit = "account.move.line" | ||
|
|
||
| # pylint: disable=W8110 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please remove |
||
| @api.depends("purchase_price", "price_subtotal") | ||
| def _compute_margin(self): | ||
| invoice_lines_with_downpayment = self.filtered( | ||
| lambda x: any(x.sale_line_ids.mapped("is_downpayment")) | ||
| ) | ||
| invoice_lines_with_downpayment.update( | ||
| { | ||
| "margin": 0.0, | ||
| "margin_signed": 0.0, | ||
| "margin_percent": 0.0, | ||
| } | ||
| ) | ||
| super(AccountMoveLine, self - invoice_lines_with_downpayment)._compute_margin() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # Copyright 2017-2018 Tecnativa - Sergio Teruel | ||
| # Copyright 2019 Tecnativa - Carlos Dauden | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
|
||
| from odoo import models | ||
|
|
||
|
|
||
| class SaleOrderLine(models.Model): | ||
| _inherit = "sale.order.line" | ||
|
|
||
| def _prepare_invoice_line(self, **optional_values): | ||
| vals = super()._prepare_invoice_line(**optional_values) | ||
| vals["purchase_price"] = self.sudo().purchase_price | ||
| return vals |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [build-system] | ||
| requires = ["whool"] | ||
| build-backend = "whool.buildapi" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| - [Tecnativa](https://www.tecnativa.com): | ||
| - Sergio Teruel | ||
| - Carlos Dauden | ||
| - Víctor Martínez | ||
| - [Open Source Integrators](https://www.opensourceintegrators.com): | ||
| - Bhavesh Odedra | ||
| - Daniel Reis \<<dreis@opensourceintegrators.com>\> | ||
| - [Factor Libre](https://www.factorlibre.com): | ||
| - Luis J. Salvatierra | ||
| - [Avoin.Systems](https://avoin.systems/): | ||
| - Nedas Żilinskas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| This module propagates purchase price from sale order line to invoice | ||
| and discards the invoice lines coming from sale order lines with | ||
| down-payment when computing the margin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| This module is autoinstalable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| This module also needs a security group to show margins. | ||
|
|
||
| 1. To activate it go to user and active "Show Invoice Margin" in | ||
| security options. |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the pylint disable