[IMP] product_packaging_dimension: Don't use max_weight anymore#1386
Merged
OCA-git-bot merged 2 commits intoSep 27, 2023
Merged
Conversation
Contributor
Author
jbaudoux
reviewed
Jul 14, 2023
rousseldenis
force-pushed
the
16.0-fix-product_packaging_dimension-dro
branch
from
23a3da2 to
fefcce0
Compare
jbaudoux
approved these changes
Jul 14, 2023
jbaudoux
reviewed
Jul 14, 2023
rousseldenis
force-pushed
the
16.0-fix-product_packaging_dimension-dro
branch
from
fefcce0 to
3e5467b
Compare
As max_weight is defined now on stock.package.type, rely on that one. Migrate data that was filled in to weight field.
rousseldenis
force-pushed
the
16.0-fix-product_packaging_dimension-dro
branch
from
3e5467b to
3b66da6
Compare
Contributor
Author
Contributor
Don't rely 😉 This PR relates to my comment here Cc @sebalix |
lmignon
approved these changes
Sep 27, 2023
Contributor
Author
|
/ocabot merge nobump |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 3d7fce2. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As max_weight is defined now on stock.package.type, rely on that one.
Migrate data that was filled in to weight field.
Added string label to packaging_length too.