Skip to content

[IMP] product_packaging_dimension: Don't use max_weight anymore #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OCA-git-bot merged 2 commits into from
Sep 27, 2023
Merged

[IMP] product_packaging_dimension: Don't use max_weight anymore #1386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e44cd81
[IMP] product_packaging_dimension: Don't use max_weight anymore
rousseldenis Jul 14, 2023
3b66da6
[IMP] product_packaging_dimension: Add string to length label
rousseldenis Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion product_packaging_dimension/__manifest__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
{
"name": "Product Packaging Dimension",
"summary": "Manage packaging dimensions and weight",
"version": "16.0.1.0.2",
"version": "16.0.1.1.0",
"category": "Product",
"author": "Camptocamp, Akretion, Odoo Community Association (OCA)",
"license": "AGPL-3",
Expand Down
22 changes: 22 additions & 0 deletions product_packaging_dimension/migrations/16.0.1.1.0/post-migrate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Copyright 2023 ACSONE SA/NV
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
from openupgradelib import openupgrade


def _move_max_weight(env):
"""
Move max_weight value to weight if not defined
"""
query = """
UPDATE product_packaging
SET weight = max_weight
WHERE weight IS NULL OR weight = 0.0
AND max_weight IS NOT NULL
AND product_id IS NOT NULL
"""
openupgrade.logged_query(env.cr, query)


@openupgrade.migrate()
def migrate(env, version):
_move_max_weight(env)
9 changes: 4 additions & 5 deletions product_packaging_dimension/models/product_packaging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@ class ProductPackaging(models.Model):
("positive_width", "CHECK(width>=0)", "Width must be positive"),
("positive_length", "CHECK(packaging_length>=0)", "Length must be positive"),
(
"positive_max_weight",
"CHECK(max_weight>=0)",
"Max Weight must be positive",
Comment thread
rousseldenis marked this conversation as resolved.
"positive_weight",
"CHECK(weight>=0)",
"Weight must be positive",
),
]
height = fields.Integer()
width = fields.Integer()
packaging_length = fields.Integer()
packaging_length = fields.Integer(string="Length")

length_uom_id = fields.Many2one(
"uom.uom",
Expand All @@ -41,7 +41,6 @@ class ProductPackaging(models.Model):
)

weight = fields.Float()
max_weight = fields.Float("Maximum Weight")
weight_uom_id = fields.Many2one(
"uom.uom",
string="Weight Units of Measure",
Expand Down
7 changes: 0 additions & 7 deletions product_packaging_dimension/views/product_packaging.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,6 @@
</group>
</group>
<group string="Weight">
<group id="group_max_weight">
<label for="max_weight" />
<div class="o_row" name="max_weight">
<field name="max_weight" />
<span><field name="weight_uom_name" /></span>
</div>
</group>
<group id="group_weight">
<label for="weight" />
<div class="o_row" name="weight">
Expand Down