[19.0][IMP] product_state: fix domain filter for state products action#2278
[19.0][IMP] product_state: fix domain filter for state products action#2278MohamedOsman7 wants to merge 1 commit into
Conversation
|
Hi @emagdalenaC2i, |
| "website": "https://github.com/OCA/product-attribute", | ||
| "category": "Product", | ||
| "version": "19.0.1.0.0", | ||
| "version": "19.0.1.0.1", |
There was a problem hiding this comment.
I think the version does not need to be updated manually, since it should be handled automatically when the merge command is executed.
Other than that, LGTM!
MohamedOsman7
force-pushed
the
19.0-fix-product_state
branch
from
53f0e5c to
6562479
Compare
|
@pedrobaeza Can you please merge in order to continue on #2275 |
| @@ -35,10 +35,10 @@ Product State | |||
| This module introduces the state field on product template and allows | |||
| <field name="view_mode">kanban,form,list</field> | ||
| <field name="context">{}</field> | ||
| <field name="domain">[('product_state_id', '=', id)]</field> | ||
| <field name="domain">[('product_state_id', '=', active_id)]</field> |
There was a problem hiding this comment.
I'm not sure this active_id will always contain the correct data.
There was a problem hiding this comment.
It works with active_id when I trigger it from the state form, but yeah, not sure if that’s always safe.
Do you have a best practice for this?
MohamedOsman7
force-pushed
the
19.0-fix-product_state
branch
from
6562479 to
930ce0f
Compare
|
This PR has the |
5 participants
solves: #2275 (review)