Skip to content

[19.0][IMP] product_state: fix domain filter for state products action #2278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MohamedOsman7 wants to merge 1 commit into
base: 19.0
Choose a base branch
from
+17 −17
Open

[19.0][IMP] product_state: fix domain filter for state products action #2278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions product_state/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ Product State
This module introduces the state field on product template and allows
Copy link
Copy Markdown
Member

@pedrobaeza pedrobaeza May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't do this change.

simple product life cycle:

- draft: In Development
- sellable: Normal
- end: End of Lifecycle
- obsolete: Obsolete
- draft: In Development
- sellable: Normal
- end: End of Lifecycle
- obsolete: Obsolete

**Table of contents**

Expand Down Expand Up @@ -75,18 +75,18 @@ Authors
Contributors
------------

- Cedric Pigeon <cedric.pigeon@acsone.eu>
- Alexandre Saunier <alexandre.saunier@camptocamp.com>
- Nikul Chaudhary <nikulchaudhary2112@gmail.com>
- Eduardo Magdalena <emagdalena@c2i.es> (C2i Change 2 improve
http://www.c2i.es)
- Andrii Skrypka <andrijskrypa@ukr.net>
- Denis Roussel <denis.roussel@acsone.eu>
- Riccardo Fresco <riccardo.fresco@bt-group.com>
- Nils Coenen <nils.coenen@nico-solutions.de>
- `Trobz <https://trobz.com>`__:

- Tuan Nguyen <tuanna@trobz.com>
- Cedric Pigeon <cedric.pigeon@acsone.eu>
- Alexandre Saunier <alexandre.saunier@camptocamp.com>
- Nikul Chaudhary <nikulchaudhary2112@gmail.com>
- Eduardo Magdalena <emagdalena@c2i.es> (C2i Change 2 improve
http://www.c2i.es)
- Andrii Skrypka <andrijskrypa@ukr.net>
- Denis Roussel <denis.roussel@acsone.eu>
- Riccardo Fresco <riccardo.fresco@bt-group.com>
- Nils Coenen <nils.coenen@nico-solutions.de>
- `Trobz <https://trobz.com>`__:

- Tuan Nguyen <tuanna@trobz.com>

Other credits
-------------
Expand Down
2 changes: 1 addition & 1 deletion product_state/views/product_template_views.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,6 @@
<field name="res_model">product.template</field>
<field name="view_mode">kanban,form,list</field>
<field name="context">{}</field>
<field name="domain">[('product_state_id', '=', id)]</field>
<field name="domain">[('product_state_id', '=', active_id)]</field>
Copy link
Copy Markdown
Member

@pedrobaeza pedrobaeza May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this active_id will always contain the correct data.

Copy link
Copy Markdown
Contributor Author

@MohamedOsman7 MohamedOsman7 May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works with active_id when I trigger it from the state form, but yeah, not sure if that’s always safe.

Do you have a best practice for this?

</record>
</odoo>
Loading