[19.0][IMP] database_cleanup: Purge menu has action that does not exist or has been deleted#3675
Open
quoc-pn wants to merge 1 commit into
Open
Conversation
pedrobaeza
reviewed
Jul 16, 2026
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
For not repeating the exact code for adding the entry, please refactor it a bit, and you can use Command.add for also shorting the 0, 0 lines.
quoc-pn
force-pushed
the
19.0-database_cleanup-purge-menus-invalid-actions
branch
from
July 16, 2026 14:18
7053e54 to
328a8c8
Compare
pedrobaeza
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
Some menus have actions that do not exist or have been deleted. When clicking on the menu "Purge obsolete menu entries" purge lines will be created for obsolete menus and the error below will be raised because of invalid action
Changes
Check whether the action exists by calling exists() before reading its data. If the action does not exist, create a purge line for the corresponding menu.