Skip to content

[19.0][IMP] database_cleanup: Purge menu has action that does not exist or has been deleted #3675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
quoc-pn wants to merge 1 commit into
base: 19.0
Choose a base branch
from
+7 −10
Open

[19.0][IMP] database_cleanup: Purge menu has action that does not exist or has been deleted #3675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions database_cleanup/wizards/purge_menus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# pylint: disable=consider-merging-classes-inherited
from odoo import api, fields, models
from odoo.exceptions import UserError
from odoo.fields import Command


class CleanupPurgeWizardMenu(models.TransientModel):
Expand All @@ -22,19 +23,15 @@ def find(self):
.with_context(active_test=False)
.search([("action", "!=", False)])
):
command = Command.create({"name": menu.complete_name, "menu_id": menu.id})
if not menu.action.exists():
# Menus may have actions that do not exist or have been deleted
res.append(command)
continue
if menu.action.type != "ir.actions.act_window":
continue
if menu.action.res_model and menu.action.res_model not in self.env:
res.append(
(
0,
0,
{
"name": menu.complete_name,
"menu_id": menu.id,
},
)
)
res.append(command)
if not res:
raise UserError(self.env._("No dangling menu entries found"))
return res
Expand Down
Loading