Fix #86: Validate config key in ReportManager.reconstruct()#150
Merged
himanshu231204 merged 2 commits intoJul 15, 2026
Merged
Conversation
himanshu231204
requested review from
himanshu231204
and removed request for
himanshu231204
|
🎉 Congratulations @fazalpsinfo-cmyk! Your pull request has been successfully merged into main. 🚀 Thank you for contributing to OpenAgentHQ and helping improve the project. We truly appreciate your contribution and hope to see you back with more amazing PRs! Happy Open Sourcing! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #86 -
ReportManager.reconstruct()silently creates a defaultConfig(**{})when the saved report data has noconfigkey (or an empty dict). This means reconstructed reports silently get wrong configuration values (wrong model, wrong dataset path, wrong provider), corrupting experiment records without warning.Changes
configkey exists and has valuesValueErrorwith a clear message when config is missingRelated
Fixes #86
Support open-source contributions: https://buymeacoffee.com/muhamedfazalps