Skip to content

Fix #86: Validate config key in ReportManager.reconstruct() #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
himanshu231204 merged 2 commits into from
Jul 15, 2026
+9 −1
Merged

Fix #86: Validate config key in ReportManager.reconstruct() #150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41f12dd
Fix #86: Validate config key in ReportManager.reconstruct()
Jul 15, 2026
35f04ea
Merge branch 'main' into fix-86-reconstruct-config-validation
himanshu231204 Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion openagent_eval/reports/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,10 +169,18 @@ def reconstruct(data: dict[str, Any]) -> EvaluationReport:

This is useful when loading a report and passing it to report
generators that expect the full dataclass.

Raises:
ValueError: If the ``config`` section is missing from the data.
"""
from openagent_eval.config.models import Config

config = Config(**data.get("config", {}))
config = data.get("config")
if not config:
raise ValueError(
"Cannot reconstruct EvaluationReport: 'config' section is missing from data"
)
config = Config(**config)

results = [
EvaluationResult(
Expand Down
Loading